diff mbox series

mx7dsabre: Fix dm probe pmic

Message ID 20200116164143.14908-1-offougajoris@gmail.com
State Accepted
Commit e2b14bf4ba0a151956e89c8243c10b08485a875f
Delegated to: Stefano Babic
Headers show
Series mx7dsabre: Fix dm probe pmic | expand

Commit Message

Joris OFFOUGA Jan. 16, 2020, 4:41 p.m. UTC
With commit mx7dsabre: Enable DM_ETH 0d52bab4

Device Tree has been update and change pfuze3000 node

Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Jan. 16, 2020, 4:46 p.m. UTC | #1
Hi Joris,

On Thu, Jan 16, 2020 at 1:41 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> With commit mx7dsabre: Enable DM_ETH 0d52bab4

Please reference commit like this:

With commit 0d52bab4621 ("mx7dsabre: Enable DM_ETH")

BTW, it would be better if this commit were split in two:

- One for syncing the dts
- Other one for converting to DM_ETH

>
> Device Tree has been update and change pfuze3000 node
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> ---
>  board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
> index 835eed3316..41c620795c 100644
> --- a/board/freescale/mx7dsabresd/mx7dsabresd.c
> +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
> @@ -264,7 +264,7 @@ int power_init_board(void)
>         struct udevice *dev;
>         int ret, dev_id, rev_id;
>
> -       ret = pmic_get("pfuze3000@08", &dev);
> +       ret = pmic_get("pfuze3000@8", &dev);

Thanks for the fix:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Stefano Babic Jan. 20, 2020, 8:18 p.m. UTC | #2
> With commit mx7dsabre: Enable DM_ETH 0d52bab4
> Device Tree has been update and change pfuze3000 node
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index 835eed3316..41c620795c 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -264,7 +264,7 @@  int power_init_board(void)
 	struct udevice *dev;
 	int ret, dev_id, rev_id;
 
-	ret = pmic_get("pfuze3000@08", &dev);
+	ret = pmic_get("pfuze3000@8", &dev);
 	if (ret == -ENODEV)
 		return 0;
 	if (ret != 0)