[OpenWrt-Devel,v2,5/5] hostapd: wpa_supplicant: enable proper GCMP cipher support
diff mbox series

Message ID 20200116115100.1906-5-freifunk@adrianschmutzler.de
State Under Review
Delegated to: Adrian Schmutzler
Headers show
Series
  • [OpenWrt-Devel,v2,1/5] linux-firmware: add wil6210 firmware
Related show

Commit Message

Adrian Schmutzler Jan. 16, 2020, 11:51 a.m. UTC
From: Robert Marko <robimarko@gmail.com>

This patch enables hostapd.sh to properly configure wpa_supplicant
for when GCMP is used as cipher in station mode.
Without this wpa_supplicant will be unable to connect to AP.
This is needed for wil6210 as it does not support CCMP.

Signed-off-by: Robert Marko <robimarko@gmail.com>
[remove empty default case]
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 package/network/services/hostapd/files/hostapd.sh | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jo-Philipp Wich Jan. 16, 2020, 12:04 p.m. UTC | #1
Hi,

> +	case "$wpa_cipher" in
> +		GCMP)
> +			append network_data "pairwise=GCMP" "$N$T"
> +			append network_data "group=GCMP" "$N$T"
> +		;;
> +	esac
> +

how is this supposed to work and look like in uci? I couldn't find any
other references to `$wpa_cipher` in hostapd.sh

>  	[ "$mode" = mesh ] || {
>  		case "$wpa" in
>  			1)
> 


~ Jo

Patch
diff mbox series

diff --git a/package/network/services/hostapd/files/hostapd.sh b/package/network/services/hostapd/files/hostapd.sh
index ab86638e11..8889ee9f4c 100644
--- a/package/network/services/hostapd/files/hostapd.sh
+++ b/package/network/services/hostapd/files/hostapd.sh
@@ -1013,6 +1013,13 @@  wpa_supplicant_add_network() {
 		;;
 	esac
 
+	case "$wpa_cipher" in
+		GCMP)
+			append network_data "pairwise=GCMP" "$N$T"
+			append network_data "group=GCMP" "$N$T"
+		;;
+	esac
+
 	[ "$mode" = mesh ] || {
 		case "$wpa" in
 			1)