| Message ID | 20191209092147.22901-10-kishon@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add PCIe support to TI's J721E SoC | expand |
On Mon, Dec 09, 2019 at 02:51:43PM +0530, Kishon Vijay Abraham I wrote: > Add host mode dt-bindings for TI's J721E SoC. > > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > .../bindings/pci/ti,j721e-pci-host.yaml | 161 ++++++++++++++++++ > 1 file changed, 161 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > > diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > new file mode 100644 > index 000000000000..96184e1f419f > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > @@ -0,0 +1,161 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/ > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/pci/ti,j721e-pci-host.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: TI J721E PCI Host (PCIe Wrapper) > + > +maintainers: > + - Kishon Vijay Abraham I <kishon@ti.com> There's now a PCI bus schema. Reference it here: allOf: - $ref: "/schemas/pci/pci-bus.yaml#" > + > +properties: > + compatible: > + enum: > + - ti,j721e-pcie-host Indentation. > + > + reg: > + maxItems: 4 > + > + reg-names: > + items: > + - const: intd_cfg > + - const: user_cfg > + - const: reg > + - const: cfg > + > + ti,syscon-pcie-ctrl: > + description: Phandle to the SYSCON entry required for configuring PCIe mode > + and link speed. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/phandle You can drop the 'allOf' here if there aren't more constraints. > + > + max-link-speed: > + minimum: 1 > + maximum: 3 > + > + num-lanes: > + minimum: 1 > + maximum: 2 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: clock-specifier to represent input to the PCIe > + > + clock-names: > + items: > + - const: fck > + > + "#address-cells": > + const: 3 > + > + "#size-cells": > + const: 2 > + > + bus-range: > + description: Range of bus numbers associated with this controller. Drop these 3 as they are all standard. > + > + cdns,max-outbound-regions: > + description: As defined in > + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > + allOf: > + - $ref: /schemas/types.yaml#/definitions/int32 Can be negative? Use uint32. The int* definitions are kind of broken until dtc is fixed to maintain sign. > + - enum: [16] const: 16 > + > + cdns,no-bar-match-nbits: > + description: As defined in > + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > + allOf: > + - $ref: /schemas/types.yaml#/definitions/int32 > + - enum: [64] > + > + vendor-id: > + const: 0x104c > + description: As defined in > + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt And elsewhere. Drop the description. > + > + device-id: > + const: 0xb00d > + description: As defined in > + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > + > + msi-map: true > + > + dma-coherent: > + description: Indicates that the PCIe IP block can ensure the coherency > + > + ranges: true Don't you know how many? > + > + reset-gpios: > + description: GPIO specifier for the PERST# signal > + > + phys: > + description: As defined in > + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > + > + phy-names: > + description: As defined in > + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > + > +required: > + - compatible > + - reg > + - reg-names > + - ti,syscon-pcie-ctrl > + - max-link-speed > + - num-lanes > + - power-domains > + - clocks > + - clock-names > + - "#address-cells" > + - "#size-cells" Can drop these 2. The bus schema requires them. > + - bus-range > + - cdns,max-outbound-regions > + - cdns,no-bar-match-nbits > + - vendor-id > + - device-id > + - msi-map > + - dma-coherent > + - ranges Can drop, too. > + - reset-gpios Isn't having this board dependent? > + - phys > + - phy-names > + > +examples: > + - | > + #include <dt-bindings/soc/ti,sci_pm_domain.h> > + #include <dt-bindings/gpio/gpio.h> > + > + > + pcie0_rc: pcie@2900000 { > + compatible = "ti,j721e-pcie-host"; > + reg = <0x00 0x02900000 0x00 0x1000>, > + <0x00 0x02907000 0x00 0x400>, > + <0x00 0x0d000000 0x00 0x00800000>, > + <0x00 0x10000000 0x00 0x00001000>; > + reg-names = "intd_cfg", "user_cfg", "reg", "cfg"; > + ti,syscon-pcie-ctrl = <&pcie0_ctrl>; > + max-link-speed = <3>; > + num-lanes = <2>; > + power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 239 1>; > + clock-names = "fck"; > + #address-cells = <3>; > + #size-cells = <2>; > + bus-range = <0x0 0xf>; > + cdns,max-outbound-regions = <16>; > + cdns,no-bar-match-nbits = <64>; > + vendor-id = /bits/ 16 <0x104c>; > + device-id = /bits/ 16 <0xb00d>; > + msi-map = <0x0 &gic_its 0x0 0x10000>; > + dma-coherent; > + reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>; > + phys = <&serdes0_pcie_link>; > + phy-names = "pcie_phy"; > + ranges = <0x01000000 0x0 0x10001000 0x00 0x10001000 0x0 0x0010000>, > + <0x02000000 0x0 0x10011000 0x00 0x10011000 0x0 0x7fef000>; > + }; > -- > 2.17.1 >
Hi, On 19/12/19 5:38 am, Rob Herring wrote: > On Mon, Dec 09, 2019 at 02:51:43PM +0530, Kishon Vijay Abraham I wrote: >> Add host mode dt-bindings for TI's J721E SoC. >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> .../bindings/pci/ti,j721e-pci-host.yaml | 161 ++++++++++++++++++ >> 1 file changed, 161 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml >> new file mode 100644 >> index 000000000000..96184e1f419f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml >> @@ -0,0 +1,161 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/ >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/pci/ti,j721e-pci-host.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: TI J721E PCI Host (PCIe Wrapper) >> + >> +maintainers: >> + - Kishon Vijay Abraham I <kishon@ti.com> > > There's now a PCI bus schema. Reference it here: > > allOf: > - $ref: "/schemas/pci/pci-bus.yaml#" > >> + >> +properties: >> + compatible: >> + enum: >> + - ti,j721e-pcie-host > > Indentation. > >> + >> + reg: >> + maxItems: 4 >> + >> + reg-names: >> + items: >> + - const: intd_cfg >> + - const: user_cfg >> + - const: reg >> + - const: cfg >> + >> + ti,syscon-pcie-ctrl: >> + description: Phandle to the SYSCON entry required for configuring PCIe mode >> + and link speed. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/phandle > > You can drop the 'allOf' here if there aren't more constraints. > >> + >> + max-link-speed: >> + minimum: 1 >> + maximum: 3 >> + >> + num-lanes: >> + minimum: 1 >> + maximum: 2 >> + >> + power-domains: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: clock-specifier to represent input to the PCIe >> + >> + clock-names: >> + items: >> + - const: fck >> + > >> + "#address-cells": >> + const: 3 >> + >> + "#size-cells": >> + const: 2 >> + >> + bus-range: >> + description: Range of bus numbers associated with this controller. > > Drop these 3 as they are all standard. > >> + >> + cdns,max-outbound-regions: >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/int32 > > Can be negative? Use uint32. > > The int* definitions are kind of broken until dtc is fixed to maintain > sign. > >> + - enum: [16] > > const: 16 > >> + >> + cdns,no-bar-match-nbits: >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/int32 >> + - enum: [64] >> + >> + vendor-id: >> + const: 0x104c >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > > And elsewhere. Drop the description. > >> + >> + device-id: >> + const: 0xb00d >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt >> + >> + msi-map: true >> + >> + dma-coherent: >> + description: Indicates that the PCIe IP block can ensure the coherency >> + >> + ranges: true > > Don't you know how many? > >> + >> + reset-gpios: >> + description: GPIO specifier for the PERST# signal >> + >> + phys: >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt >> + >> + phy-names: >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - ti,syscon-pcie-ctrl >> + - max-link-speed >> + - num-lanes >> + - power-domains >> + - clocks >> + - clock-names > >> + - "#address-cells" >> + - "#size-cells" > > Can drop these 2. The bus schema requires them. > >> + - bus-range >> + - cdns,max-outbound-regions >> + - cdns,no-bar-match-nbits >> + - vendor-id >> + - device-id >> + - msi-map >> + - dma-coherent >> + - ranges > > Can drop, too. > >> + - reset-gpios > > Isn't having this board dependent? All board dts files should have it though. I'll fix all the comments given here. Thanks Kishon
Hi Rob, On 19/12/19 5:38 AM, Rob Herring wrote: > On Mon, Dec 09, 2019 at 02:51:43PM +0530, Kishon Vijay Abraham I wrote: >> Add host mode dt-bindings for TI's J721E SoC. >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> .../bindings/pci/ti,j721e-pci-host.yaml | 161 ++++++++++++++++++ >> 1 file changed, 161 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml >> new file mode 100644 >> index 000000000000..96184e1f419f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml >> @@ -0,0 +1,161 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/ >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/pci/ti,j721e-pci-host.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: TI J721E PCI Host (PCIe Wrapper) >> + >> +maintainers: >> + - Kishon Vijay Abraham I <kishon@ti.com> > > There's now a PCI bus schema. Reference it here: > > allOf: > - $ref: "/schemas/pci/pci-bus.yaml#" > >> + >> +properties: >> + compatible: >> + enum: >> + - ti,j721e-pcie-host > > Indentation. > >> + >> + reg: >> + maxItems: 4 >> + >> + reg-names: >> + items: >> + - const: intd_cfg >> + - const: user_cfg >> + - const: reg >> + - const: cfg >> + >> + ti,syscon-pcie-ctrl: >> + description: Phandle to the SYSCON entry required for configuring PCIe mode >> + and link speed. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/phandle > > You can drop the 'allOf' here if there aren't more constraints. Do you mean I don't have to include phandle schema here? I don't seem to be able to include $ref without allOf. Thanks Kishon
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml new file mode 100644 index 000000000000..96184e1f419f --- /dev/null +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml @@ -0,0 +1,161 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/ +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/pci/ti,j721e-pci-host.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: TI J721E PCI Host (PCIe Wrapper) + +maintainers: + - Kishon Vijay Abraham I <kishon@ti.com> + +properties: + compatible: + enum: + - ti,j721e-pcie-host + + reg: + maxItems: 4 + + reg-names: + items: + - const: intd_cfg + - const: user_cfg + - const: reg + - const: cfg + + ti,syscon-pcie-ctrl: + description: Phandle to the SYSCON entry required for configuring PCIe mode + and link speed. + allOf: + - $ref: /schemas/types.yaml#/definitions/phandle + + max-link-speed: + minimum: 1 + maximum: 3 + + num-lanes: + minimum: 1 + maximum: 2 + + power-domains: + maxItems: 1 + + clocks: + maxItems: 1 + description: clock-specifier to represent input to the PCIe + + clock-names: + items: + - const: fck + + "#address-cells": + const: 3 + + "#size-cells": + const: 2 + + bus-range: + description: Range of bus numbers associated with this controller. + + cdns,max-outbound-regions: + description: As defined in + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt + allOf: + - $ref: /schemas/types.yaml#/definitions/int32 + - enum: [16] + + cdns,no-bar-match-nbits: + description: As defined in + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt + allOf: + - $ref: /schemas/types.yaml#/definitions/int32 + - enum: [64] + + vendor-id: + const: 0x104c + description: As defined in + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt + + device-id: + const: 0xb00d + description: As defined in + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt + + msi-map: true + + dma-coherent: + description: Indicates that the PCIe IP block can ensure the coherency + + ranges: true + + reset-gpios: + description: GPIO specifier for the PERST# signal + + phys: + description: As defined in + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt + + phy-names: + description: As defined in + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt + +required: + - compatible + - reg + - reg-names + - ti,syscon-pcie-ctrl + - max-link-speed + - num-lanes + - power-domains + - clocks + - clock-names + - "#address-cells" + - "#size-cells" + - bus-range + - cdns,max-outbound-regions + - cdns,no-bar-match-nbits + - vendor-id + - device-id + - msi-map + - dma-coherent + - ranges + - reset-gpios + - phys + - phy-names + +examples: + - | + #include <dt-bindings/soc/ti,sci_pm_domain.h> + #include <dt-bindings/gpio/gpio.h> + + + pcie0_rc: pcie@2900000 { + compatible = "ti,j721e-pcie-host"; + reg = <0x00 0x02900000 0x00 0x1000>, + <0x00 0x02907000 0x00 0x400>, + <0x00 0x0d000000 0x00 0x00800000>, + <0x00 0x10000000 0x00 0x00001000>; + reg-names = "intd_cfg", "user_cfg", "reg", "cfg"; + ti,syscon-pcie-ctrl = <&pcie0_ctrl>; + max-link-speed = <3>; + num-lanes = <2>; + power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>; + clocks = <&k3_clks 239 1>; + clock-names = "fck"; + #address-cells = <3>; + #size-cells = <2>; + bus-range = <0x0 0xf>; + cdns,max-outbound-regions = <16>; + cdns,no-bar-match-nbits = <64>; + vendor-id = /bits/ 16 <0x104c>; + device-id = /bits/ 16 <0xb00d>; + msi-map = <0x0 &gic_its 0x0 0x10000>; + dma-coherent; + reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>; + phys = <&serdes0_pcie_link>; + phy-names = "pcie_phy"; + ranges = <0x01000000 0x0 0x10001000 0x00 0x10001000 0x0 0x0010000>, + <0x02000000 0x0 0x10011000 0x00 0x10011000 0x0 0x7fef000>; + };
Add host mode dt-bindings for TI's J721E SoC. Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- .../bindings/pci/ti,j721e-pci-host.yaml | 161 ++++++++++++++++++ 1 file changed, 161 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml