diff mbox series

[ovs-dev,04/20] netdev-offload-dpdk: Fix typo

Message ID 20191120152826.25074-5-elibr@mellanox.com
State Changes Requested
Delegated to: Ilya Maximets
Headers show
Series netdev datapath actions offload | expand

Commit Message

Eli Britstein Nov. 20, 2019, 3:28 p.m. UTC 
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein <elibr@mellanox.com>
Reviewed-by: Oz Shlomo <ozsh@mellanox.com>
---
 lib/netdev-offload-dpdk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ilya Maximets Dec. 4, 2019, 2:27 p.m. UTC | #1 
On 20.11.2019 16:28, Eli Britstein wrote:
> Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> Reviewed-by: Oz Shlomo <ozsh@mellanox.com>
> ---
>  lib/netdev-offload-dpdk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> index 9882e1d23..6e1ca8a0d 100644
> --- a/lib/netdev-offload-dpdk.c
> +++ b/lib/netdev-offload-dpdk.c
> @@ -150,7 +150,7 @@ netdev_offload_dpdk_add_flow(struct netdev *netdev,
>                                         actions.actions, &error);
>  
>      if (!flow) {
> -        VLOG_ERR("%s: rte flow creat error: %u : message : %s\n",
> +        VLOG_ERR("%s: rte flow create error: %u : message : %s\n",

I think it was a subtle humorous allusion to O_CREAT. :)

BTW, if you're fixing this log message, you could make it more
human-readable, e.g. "%s: Failed to create flow: %s (%u)".

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 9882e1d23..6e1ca8a0d 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -150,7 +150,7 @@  netdev_offload_dpdk_add_flow(struct netdev *netdev,
                                        actions.actions, &error);
 
     if (!flow) {
-        VLOG_ERR("%s: rte flow creat error: %u : message : %s\n",
+        VLOG_ERR("%s: rte flow create error: %u : message : %s\n",
                  netdev_get_name(netdev), error.type, error.message);
         ret = -1;
         goto out;