| Message ID | 20191118011125.17098-1-flavio@flaviof.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev,ovn,v3] vagrant: Use centos-8 box from official location | expand |
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Flavio Fernandes <flaviof@redhat.com> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Flavio Fernandes <flavio@flaviof.com> Lines checked: 61, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
Hi Flavio, What's the difference between v2 and v3? 0-day robot is complaining because your git-configured e-mail address is different from the one in the Signed-off-by: line. On 11/17/19 8:11 PM, Flavio Fernandes wrote: > From: Flavio Fernandes <flaviof@redhat.com> > > Prefer the usage of "vagrant box update" instead of > "dnf update" to save provisioning time. > > Also, as part of provisioning centos-8, use pip to install > packages twisted, zope-interface and six. > > Signed-off-by: Flavio Fernandes <flavio@flaviof.com> > --- > Vagrantfile | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Vagrantfile b/Vagrantfile > index 88c981c71..f0526ec48 100644 > --- a/Vagrantfile > +++ b/Vagrantfile > @@ -37,7 +37,7 @@ apt-get -y install build-essential fakeroot graphviz autoconf automake bzip2 \ > SCRIPT > > $bootstrap_ovs_centos7 = <<SCRIPT > -yum -y update ; # save your time. "vagrant box update" is your friend > +#yum -y update ; # save your time. "vagrant box update" is your friend > yum -y install autoconf automake openssl-devel libtool \ > python3-devel python3-twisted-core python3-zope-interface \ > desktop-file-utils groff graphviz rpmdevtools nc curl \ > @@ -48,16 +48,15 @@ pip3 install six > SCRIPT > > $bootstrap_ovs_centos = <<SCRIPT > -dnf -y update ||: ; # save your time. "vagrant box update" is your friend > +#dnf -y update ; # save your time. "vagrant box update" is your friend > dnf -y install autoconf automake openssl-devel libtool \ > - python3-devel \ > - python3-twisted python3-zope-interface python3-six \ > + python3-devel python3-pip \ > desktop-file-utils graphviz rpmdevtools nc curl \ > wget checkpolicy selinux-policy-devel \ > libcap-ng-devel kernel-devel-`uname -r` ethtool \ > lftp > echo "search extra update built-in" >/etc/depmod.d/search_path.conf > -pip3 install pyftpdlib tftpy > +pip3 install pyftpdlib tftpy twisted zope-interface six > SCRIPT > > $configure_ovs = <<SCRIPT > @@ -153,7 +152,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| > end > config.vm.define "centos-8" do |centos| > centos.vm.hostname = "centos-8" > - centos.vm.box = "generic/centos8" > + centos.vm.box = "centos/8" > centos.vm.synced_folder ".", "/vagrant", disabled: true > centos.vm.synced_folder ".", "/vagrant/ovn", type: "rsync" > centos.vm.synced_folder "../ovs", "/vagrant/ovs", type: "rsync" >
Apologies, I did not see that you corrected this in v4. On 11/18/19 4:55 PM, Mark Michelson wrote: > Hi Flavio, > > What's the difference between v2 and v3? > > 0-day robot is complaining because your git-configured e-mail address is > different from the one in the Signed-off-by: line. > > On 11/17/19 8:11 PM, Flavio Fernandes wrote: >> From: Flavio Fernandes <flaviof@redhat.com> >> >> Prefer the usage of "vagrant box update" instead of >> "dnf update" to save provisioning time. >> >> Also, as part of provisioning centos-8, use pip to install >> packages twisted, zope-interface and six. >> >> Signed-off-by: Flavio Fernandes <flavio@flaviof.com> >> --- >> Vagrantfile | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/Vagrantfile b/Vagrantfile >> index 88c981c71..f0526ec48 100644 >> --- a/Vagrantfile >> +++ b/Vagrantfile >> @@ -37,7 +37,7 @@ apt-get -y install build-essential fakeroot graphviz >> autoconf automake bzip2 \ >> SCRIPT >> $bootstrap_ovs_centos7 = <<SCRIPT >> -yum -y update ; # save your time. "vagrant box update" is your friend >> +#yum -y update ; # save your time. "vagrant box update" is your friend >> yum -y install autoconf automake openssl-devel libtool \ >> python3-devel python3-twisted-core >> python3-zope-interface \ >> desktop-file-utils groff graphviz rpmdevtools nc curl \ >> @@ -48,16 +48,15 @@ pip3 install six >> SCRIPT >> $bootstrap_ovs_centos = <<SCRIPT >> -dnf -y update ||: ; # save your time. "vagrant box update" is your >> friend >> +#dnf -y update ; # save your time. "vagrant box update" is your friend >> dnf -y install autoconf automake openssl-devel libtool \ >> - python3-devel \ >> - python3-twisted python3-zope-interface python3-six \ >> + python3-devel python3-pip \ >> desktop-file-utils graphviz rpmdevtools nc curl \ >> wget checkpolicy selinux-policy-devel \ >> libcap-ng-devel kernel-devel-`uname -r` ethtool \ >> lftp >> echo "search extra update built-in" >/etc/depmod.d/search_path.conf >> -pip3 install pyftpdlib tftpy >> +pip3 install pyftpdlib tftpy twisted zope-interface six >> SCRIPT >> $configure_ovs = <<SCRIPT >> @@ -153,7 +152,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do >> |config| >> end >> config.vm.define "centos-8" do |centos| >> centos.vm.hostname = "centos-8" >> - centos.vm.box = "generic/centos8" >> + centos.vm.box = "centos/8" >> centos.vm.synced_folder ".", "/vagrant", disabled: true >> centos.vm.synced_folder ".", "/vagrant/ovn", type: "rsync" >> centos.vm.synced_folder "../ovs", "/vagrant/ovs", type: "rsync" >> >
diff --git a/Vagrantfile b/Vagrantfile index 88c981c71..f0526ec48 100644 --- a/Vagrantfile +++ b/Vagrantfile @@ -37,7 +37,7 @@ apt-get -y install build-essential fakeroot graphviz autoconf automake bzip2 \ SCRIPT $bootstrap_ovs_centos7 = <<SCRIPT -yum -y update ; # save your time. "vagrant box update" is your friend +#yum -y update ; # save your time. "vagrant box update" is your friend yum -y install autoconf automake openssl-devel libtool \ python3-devel python3-twisted-core python3-zope-interface \ desktop-file-utils groff graphviz rpmdevtools nc curl \ @@ -48,16 +48,15 @@ pip3 install six SCRIPT $bootstrap_ovs_centos = <<SCRIPT -dnf -y update ||: ; # save your time. "vagrant box update" is your friend +#dnf -y update ; # save your time. "vagrant box update" is your friend dnf -y install autoconf automake openssl-devel libtool \ - python3-devel \ - python3-twisted python3-zope-interface python3-six \ + python3-devel python3-pip \ desktop-file-utils graphviz rpmdevtools nc curl \ wget checkpolicy selinux-policy-devel \ libcap-ng-devel kernel-devel-`uname -r` ethtool \ lftp echo "search extra update built-in" >/etc/depmod.d/search_path.conf -pip3 install pyftpdlib tftpy +pip3 install pyftpdlib tftpy twisted zope-interface six SCRIPT $configure_ovs = <<SCRIPT @@ -153,7 +152,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| end config.vm.define "centos-8" do |centos| centos.vm.hostname = "centos-8" - centos.vm.box = "generic/centos8" + centos.vm.box = "centos/8" centos.vm.synced_folder ".", "/vagrant", disabled: true centos.vm.synced_folder ".", "/vagrant/ovn", type: "rsync" centos.vm.synced_folder "../ovs", "/vagrant/ovs", type: "rsync"