From patchwork Sat Nov 9 03:11:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gowrishankar Muthukrishnan X-Patchwork-Id: 1192357 X-Patchwork-Delegate: i.maximets@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="KJIWj1Q0"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4792H54mDrz9sPF for ; Sat, 9 Nov 2019 14:11:44 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 843B1CD9; Sat, 9 Nov 2019 03:11:42 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3FF21CD3 for ; Sat, 9 Nov 2019 03:11:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 062E1EC for ; Sat, 9 Nov 2019 03:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573269098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yYiilYl4cGNX2WgBHrflU8SnUmg1y93suK2oCUyYC50=; b=KJIWj1Q0M3aOaCmTs3Y9aWA6hqUn0q/e8d4S4abJv6PrI5SRHXA3FMR6zw6IwCjDloEaTi pQskY+Rcf48K6gBz2jZNEcaQjaH5iMxK5bdftSTLRf8HYLFsZGuPYHP/cx9RlmDRDRNSeG y6VRYraQm9iebNbmFw4YQtzrJZfPjPs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-boY8vH8QOBK08GnPlVWYsA-1; Fri, 08 Nov 2019 22:11:35 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1B018017E0; Sat, 9 Nov 2019 03:11:33 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-39.sin2.redhat.com [10.67.116.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0103B1001925; Sat, 9 Nov 2019 03:11:31 +0000 (UTC) From: Gowrishankar Muthukrishnan To: dev@openvswitch.org Date: Sat, 9 Nov 2019 08:41:27 +0530 Message-Id: <20191109031127.16292-1-gmuthukr@redhat.com> In-Reply-To: <20191022093446.24170-1-gmuthukr@redhat.com> References: <20191022093446.24170-1-gmuthukr@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: boY8vH8QOBK08GnPlVWYsA-1 X-Mimecast-Spam-Score: 0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH v3] dpif-netdev: log rxq assignment in isolated pmd X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org There is no log about isolated rxq assignment in a pmd today, which sometimes could be useful to trace rxq/pmd pinning, when debugging with log. Ovs-appctl dpif-netdev/pmd-rxq-show reports about it already, but logging is helpful to trace pinning in time. Changes: v3: correction on pmd unref and numa_id. Reported-at: https://bugzilla.redhat.com/1728616 Signed-off-by: Gowrishankar Muthukrishnan --- lib/dpif-netdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 4546b55e8..aeae66aea 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4572,6 +4572,10 @@ rxq_scheduling(struct dp_netdev *dp, bool pinned) OVS_REQUIRES(dp->port_mutex) } else { q->pmd = pmd; pmd->isolated = true; + VLOG_INFO("Core %d on numa node %d assigned port \'%s\' " + "rx queue %d.", pmd->core_id, pmd->numa_id, + netdev_rxq_get_name(q->rx), + netdev_rxq_get_queue_id(q->rx)); dp_netdev_pmd_unref(pmd); } } else if (!pinned && q->core_id == OVS_CORE_UNSPEC) {