From patchwork Fri Nov 8 08:55:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhike Wang X-Patchwork-Id: 1191742 X-Patchwork-Delegate: i.maximets@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="NZSzND4l"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 478YzZ48DJz9sNx for ; Fri, 8 Nov 2019 19:56:42 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1F54CCD5; Fri, 8 Nov 2019 08:56:41 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9744CCB1 for ; Fri, 8 Nov 2019 08:56:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1A9B3EC for ; Fri, 8 Nov 2019 08:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=8GXK5g6HH1WOkfseA/ 9D+U0zx4xXfq6frIsZqQmA4x0=; b=NZSzND4lry59wfr9WSlKPA3jsHmySFmwbG m60s77wlEWhg/hxrGpyRsba2Ja2PMSJ0Jj/uCGqIYrcfxlhQZeIy0BDzShWkKurM P/ySddgSz8enZAi3+yLd2cM7RWMg0QAZhzzgugilOP2li1tIYaCqdpkd+MHxLcVa CKWp5RdPg= Received: from localhost.localdomain (unknown [106.38.115.15]) by smtp9 (Coremail) with SMTP id DcCowAAHQvhrLcVd90BzIA--.55581S2; Fri, 08 Nov 2019 16:55:13 +0800 (CST) From: Zhike Wang To: dev@openvswitch.org Date: Fri, 8 Nov 2019 16:55:06 +0800 Message-Id: <1573203306-9860-1-git-send-email-wangzk320@163.com> X-Mailer: git-send-email 1.8.3.1 X-CM-TRANSID: DcCowAAHQvhrLcVd90BzIA--.55581S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4Ri3ktUUUUU X-Originating-IP: [106.38.115.15] X-CM-SenderInfo: pzdqw6bntsiqqrwthudrp/1tbipRFnulUMVeGddQAAss X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: wangzhike@jd.com, Zhike Wang Subject: [ovs-dev] [PATCH] netdev-dpdk: Fix dev attached flag. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org If the dev was already probed correctly, the dev attached flag should be set to true, or resource would leak during destruct. Signed-off-by: Zhike Wang --- lib/netdev-dpdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index a65540c..10e2fe9 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1728,6 +1728,9 @@ netdev_dpdk_process_devargs(struct netdev_dpdk *dev, new_port_id = DPDK_ETH_PORT_ID_INVALID; } } + } else { + dev->attached = true; + VLOG_INFO("Device '%s' attached to DPDK", devargs); } }