| Message ID | 20191030195329.19880-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] travis: Enable pdump for DPDK build. | expand |
On Wed, Oct 30, 2019 at 8:53 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > OVS has support for DPDK pdump that checked in configure script. > Enabling it to increase OVS build test coverage by the code guarded > by DPDK_PDUMP macro. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > > Travis cache should be manually cleared before pushing this change for > it to have effect. > > .travis.yml | 1 + > .travis/linux-build.sh | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 37a2ba5ce..049529d50 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -20,6 +20,7 @@ addons: > - libjemalloc1 > - libjemalloc-dev > - libnuma-dev > + - libpcap-dev > - python3-sphinx > - libelf-dev > - selinux-policy-dev > diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh > index 889c7d2fe..e11ff47ee 100755 > --- a/.travis/linux-build.sh > +++ b/.travis/linux-build.sh > @@ -124,6 +124,10 @@ function install_dpdk() > sed -i '/CONFIG_RTE_EAL_IGB_UIO=y/s/=y/=n/' build/.config > sed -i '/CONFIG_RTE_KNI_KMOD=y/s/=y/=n/' build/.config > > + # Enable pdump. This will enable building of revelant OVS code. > + sed -i '/RTE_LIBRTE_PMD_PCAP=n/s/=n/=y/' build/.config CONFIG_ for consistency with the rest? > + sed -i '/CONFIG_RTE_LIBRTE_PDUMP=n/s/=n/=y/' build/.config > + > make -j4 CC=gcc EXTRA_CFLAGS='-fPIC' > EXTRA_OPTS="$EXTRA_OPTS --with-dpdk=$(pwd)/build" > echo "Installed DPDK source in $(pwd)" > -- > 2.17.1 > Waiting for travis to finish, but the patch looks good. Reviewed-by: David Marchand <david.marchand@redhat.com> -- David Marchand
On 31.10.2019 9:02, David Marchand wrote: > On Wed, Oct 30, 2019 at 8:53 PM Ilya Maximets <i.maximets@ovn.org> wrote: >> >> OVS has support for DPDK pdump that checked in configure script. >> Enabling it to increase OVS build test coverage by the code guarded >> by DPDK_PDUMP macro. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- >> >> Travis cache should be manually cleared before pushing this change for >> it to have effect. >> >> .travis.yml | 1 + >> .travis/linux-build.sh | 4 ++++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/.travis.yml b/.travis.yml >> index 37a2ba5ce..049529d50 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -20,6 +20,7 @@ addons: >> - libjemalloc1 >> - libjemalloc-dev >> - libnuma-dev >> + - libpcap-dev >> - python3-sphinx >> - libelf-dev >> - selinux-policy-dev >> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh >> index 889c7d2fe..e11ff47ee 100755 >> --- a/.travis/linux-build.sh >> +++ b/.travis/linux-build.sh >> @@ -124,6 +124,10 @@ function install_dpdk() >> sed -i '/CONFIG_RTE_EAL_IGB_UIO=y/s/=y/=n/' build/.config >> sed -i '/CONFIG_RTE_KNI_KMOD=y/s/=y/=n/' build/.config >> >> + # Enable pdump. This will enable building of revelant OVS code. >> + sed -i '/RTE_LIBRTE_PMD_PCAP=n/s/=n/=y/' build/.config > > CONFIG_ for consistency with the rest? > >> + sed -i '/CONFIG_RTE_LIBRTE_PDUMP=n/s/=n/=y/' build/.config >> + >> make -j4 CC=gcc EXTRA_CFLAGS='-fPIC' >> EXTRA_OPTS="$EXTRA_OPTS --with-dpdk=$(pwd)/build" >> echo "Installed DPDK source in $(pwd)" >> -- >> 2.17.1 >> > > Waiting for travis to finish, but the patch looks good. > Reviewed-by: David Marchand <david.marchand@redhat.com> Thanks! I added the 'CONFIG_', fixed small typo in comment, cleared Travis cache and applied to master. Best regards, Ilya Maximets.
diff --git a/.travis.yml b/.travis.yml index 37a2ba5ce..049529d50 100644 --- a/.travis.yml +++ b/.travis.yml @@ -20,6 +20,7 @@ addons: - libjemalloc1 - libjemalloc-dev - libnuma-dev + - libpcap-dev - python3-sphinx - libelf-dev - selinux-policy-dev diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index 889c7d2fe..e11ff47ee 100755 --- a/.travis/linux-build.sh +++ b/.travis/linux-build.sh @@ -124,6 +124,10 @@ function install_dpdk() sed -i '/CONFIG_RTE_EAL_IGB_UIO=y/s/=y/=n/' build/.config sed -i '/CONFIG_RTE_KNI_KMOD=y/s/=y/=n/' build/.config + # Enable pdump. This will enable building of revelant OVS code. + sed -i '/RTE_LIBRTE_PMD_PCAP=n/s/=n/=y/' build/.config + sed -i '/CONFIG_RTE_LIBRTE_PDUMP=n/s/=n/=y/' build/.config + make -j4 CC=gcc EXTRA_CFLAGS='-fPIC' EXTRA_OPTS="$EXTRA_OPTS --with-dpdk=$(pwd)/build" echo "Installed DPDK source in $(pwd)"
OVS has support for DPDK pdump that checked in configure script. Enabling it to increase OVS build test coverage by the code guarded by DPDK_PDUMP macro. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- Travis cache should be manually cleared before pushing this change for it to have effect. .travis.yml | 1 + .travis/linux-build.sh | 4 ++++ 2 files changed, 5 insertions(+)