| Message ID | 20191023144744.1246-1-grygorii.strashko@ti.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid | expand |
On 10/23/2019 7:47 AM, Grygorii Strashko wrote: > Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode > "rgmii-rxid" which is incorrect. > Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid" > mode. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Should this have a: Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver")
On 24/10/2019 05:41, Florian Fainelli wrote: > > > On 10/23/2019 7:47 AM, Grygorii Strashko wrote: >> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode >> "rgmii-rxid" which is incorrect. >> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid" >> mode. >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > > Should this have a: > > Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver") > Yes. it should. Kishon, would you like me to re-submit or can you fix while applying?
On 24/10/19 11:12 AM, Grygorii Strashko wrote: > > > On 24/10/2019 05:41, Florian Fainelli wrote: >> >> >> On 10/23/2019 7:47 AM, Grygorii Strashko wrote: >>> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode >>> "rgmii-rxid" which is incorrect. >>> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid" >>> mode. >>> >>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> >> Should this have a: >> >> Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver") >> > > Yes. it should. > Kishon, would you like me to re-submit or can you fix while applying? I'll fix it while applying. Thanks Kishon
On 24/10/19 11:12 AM, Grygorii Strashko wrote: > > > On 24/10/2019 05:41, Florian Fainelli wrote: >> >> >> On 10/23/2019 7:47 AM, Grygorii Strashko wrote: >>> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode >>> "rgmii-rxid" which is incorrect. >>> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid" >>> mode. >>> >>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> >> Should this have a: >> >> Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver") >> > > Yes. it should. > Kishon, would you like me to re-submit or can you fix while applying? merged now, thanks! -Kishon
diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c index a52c5bb35033..a28bd15297f5 100644 --- a/drivers/phy/ti/phy-gmii-sel.c +++ b/drivers/phy/ti/phy-gmii-sel.c @@ -69,11 +69,11 @@ static int phy_gmii_sel_mode(struct phy *phy, enum phy_mode mode, int submode) break; case PHY_INTERFACE_MODE_RGMII: + case PHY_INTERFACE_MODE_RGMII_RXID: gmii_sel_mode = AM33XX_GMII_SEL_MODE_RGMII; break; case PHY_INTERFACE_MODE_RGMII_ID: - case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID: gmii_sel_mode = AM33XX_GMII_SEL_MODE_RGMII; rgmii_id = 1;
Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode "rgmii-rxid" which is incorrect. Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid" mode. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/phy/ti/phy-gmii-sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)