| Message ID | 20191022052914.12924-1-gmuthukr@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] lacp: report desync in ovs threads enabling slave | expand |
Bleep bloop. Greetings Gowrishankar Muthukrishnan, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#25 FILE: ofproto/bond.c:821:
VLOG_DBG_RL(&rl, "bond %s: slave %s: main thread not yet enabled slave",
Lines checked: 33, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email aconole@redhat.com
Thanks,
0-day Robot
On Tue, Oct 22, 2019 at 10:59:14AM +0530, Gowrishankar Muthukrishnan wrote: > It is helpful in reporting main thread that is yet to enable bond slave, > but link state was brought up by lacp thread and capture this desync > between ovs threads for debugging. > > Fixes: a8448cb170 ("lacp: Avoid packet drop on LACP bond after link up") > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr@redhat.com> Thanks, applied to master.
diff --git a/ofproto/bond.c b/ofproto/bond.c index c5d5f2c03..3b148a244 100644 --- a/ofproto/bond.c +++ b/ofproto/bond.c @@ -817,6 +817,10 @@ bond_check_admissibility(struct bond *bond, const void *slave_, * When may_enable is TRUE, it means LACP is UP and waiting for the * main thread to run LACP state machine and enable the slave. */ verdict = (slave->enabled || slave->may_enable) ? BV_ACCEPT : BV_DROP; + if (!slave->enabled && slave->may_enable) { + VLOG_DBG_RL(&rl, "bond %s: slave %s: main thread not yet enabled slave", + bond->name, bond->active_slave->name); + } goto out; case LACP_CONFIGURED: if (!bond->lacp_fallback_ab) {
It is helpful in reporting main thread that is yet to enable bond slave, but link state was brought up by lacp thread and capture this desync between ovs threads for debugging. Fixes: a8448cb170 ("lacp: Avoid packet drop on LACP bond after link up") Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr@redhat.com> --- ofproto/bond.c | 4 ++++ 1 file changed, 4 insertions(+)