| Message ID | 20191006171404.7253-1-dqfext@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: add support for en25qh16 | expand |
Hi, Deng, On 10/06/2019 08:14 PM, Deng Qingfang wrote: > External E-Mail > > > Tested on HiWiFi C526A > > Datasheet is available at: > http://www.xinyahong.com/upLoad/product/month_1411/201411201256018276.pdf > > Signed-off-by: Deng Qingfang <dqfext@gmail.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 1d8621d..cc797de 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2179,6 +2179,8 @@ static const struct flash_info spi_nor_ids[] = { > { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) }, > { "en25q80a", INFO(0x1c3014, 0, 64 * 1024, 16, > SECT_4K | SPI_NOR_DUAL_READ) }, > + { "en25qh16", INFO(0x1c7015, 0, 64 * 1024, 32, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, Looks like this flash does not support the SPINOR_OP_READ_1_1_4 (6bh) opcode, so you can't specify the SPI_NOR_QUAD_READ flag. SPINOR_OP_READ_1_4_4 will be discovered when parsing BFPT, and you'll use that instead. Would you send a v2 to drop the SPI_NOR_QUAD_READ flag or do you want me to drop it when applying? Cheers, ta > { "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) }, > { "en25qh64", INFO(0x1c7017, 0, 64 * 1024, 128, > SECT_4K | SPI_NOR_DUAL_READ) }, >
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 1d8621d..cc797de 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2179,6 +2179,8 @@ static const struct flash_info spi_nor_ids[] = { { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) }, { "en25q80a", INFO(0x1c3014, 0, 64 * 1024, 16, SECT_4K | SPI_NOR_DUAL_READ) }, + { "en25qh16", INFO(0x1c7015, 0, 64 * 1024, 32, + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) }, { "en25qh64", INFO(0x1c7017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ) },
Tested on HiWiFi C526A Datasheet is available at: http://www.xinyahong.com/upLoad/product/month_1411/201411201256018276.pdf Signed-off-by: Deng Qingfang <dqfext@gmail.com> --- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)