[U-Boot,2/2] ram: rk3328: Fix loading of skew values
diff mbox series

Message ID 17f58d8cdf7d32de26cb36950fa8676e0dd54d49.1570376078.git.simon@simonsouth.net
State Accepted
Commit c4b9d66f115657203dba6e8ed8c4b2e94d6770c0
Delegated to: Kever Yang
Headers show
Series
  • Fix memory instability on ROCK64
Related show

Commit Message

Simon South Oct. 6, 2019, 4:28 p.m. UTC
Fix a typo that caused incorrect values to be loaded into the DRAM
controller's deskew registers.

Signed-off-by: Simon South <simon@simonsouth.net>
---
 drivers/ram/rockchip/sdram_rk3328.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kever Yang Oct. 8, 2019, 2:55 a.m. UTC | #1
On 2019/10/7 上午12:28, Simon South wrote:
> Fix a typo that caused incorrect values to be loaded into the DRAM
> controller's deskew registers.
>
> Signed-off-by: Simon South <simon@simonsouth.net>
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/ram/rockchip/sdram_rk3328.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3328.c b/drivers/ram/rockchip/sdram_rk3328.c
> index 0541bbadf0..e84c9be6a2 100644
> --- a/drivers/ram/rockchip/sdram_rk3328.c
> +++ b/drivers/ram/rockchip/sdram_rk3328.c
> @@ -394,7 +394,7 @@ static void phy_cfg(struct dram_info *dram,
>   	copy_to_reg(PHY_REG(phy_base, 0x70),
>   		    &sdram_params->skew.cs0_dm0_skew[0], 44 * 4);
>   	copy_to_reg(PHY_REG(phy_base, 0xc0),
> -		    &sdram_params->skew.cs0_dm1_skew[0], 44 * 4);
> +		    &sdram_params->skew.cs1_dm0_skew[0], 44 * 4);
>   }
>   
>   static int update_refresh_reg(struct dram_info *dram)
Kever Yang Oct. 14, 2019, 10:06 a.m. UTC | #2
On 2019/10/8 上午10:55, Kever Yang wrote:
>
> On 2019/10/7 上午12:28, Simon South wrote:
>> Fix a typo that caused incorrect values to be loaded into the DRAM
>> controller's deskew registers.
>>
>> Signed-off-by: Simon South <simon@simonsouth.net>
> Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Applied to u-boot-rockchip master.
>
> Thanks,
> - Kever
>> ---
>>   drivers/ram/rockchip/sdram_rk3328.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ram/rockchip/sdram_rk3328.c 
>> b/drivers/ram/rockchip/sdram_rk3328.c
>> index 0541bbadf0..e84c9be6a2 100644
>> --- a/drivers/ram/rockchip/sdram_rk3328.c
>> +++ b/drivers/ram/rockchip/sdram_rk3328.c
>> @@ -394,7 +394,7 @@ static void phy_cfg(struct dram_info *dram,
>>       copy_to_reg(PHY_REG(phy_base, 0x70),
>>               &sdram_params->skew.cs0_dm0_skew[0], 44 * 4);
>>       copy_to_reg(PHY_REG(phy_base, 0xc0),
>> -            &sdram_params->skew.cs0_dm1_skew[0], 44 * 4);
>> +            &sdram_params->skew.cs1_dm0_skew[0], 44 * 4);
>>   }
>>     static int update_refresh_reg(struct dram_info *dram)
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot

Patch
diff mbox series

diff --git a/drivers/ram/rockchip/sdram_rk3328.c b/drivers/ram/rockchip/sdram_rk3328.c
index 0541bbadf0..e84c9be6a2 100644
--- a/drivers/ram/rockchip/sdram_rk3328.c
+++ b/drivers/ram/rockchip/sdram_rk3328.c
@@ -394,7 +394,7 @@  static void phy_cfg(struct dram_info *dram,
 	copy_to_reg(PHY_REG(phy_base, 0x70),
 		    &sdram_params->skew.cs0_dm0_skew[0], 44 * 4);
 	copy_to_reg(PHY_REG(phy_base, 0xc0),
-		    &sdram_params->skew.cs0_dm1_skew[0], 44 * 4);
+		    &sdram_params->skew.cs1_dm0_skew[0], 44 * 4);
 }
 
 static int update_refresh_reg(struct dram_info *dram)