[ovs-dev,ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."
diff mbox series

Message ID 20190930135107.16869-1-nusiddiq@redhat.com
State New
Headers show
Series
  • [ovs-dev,ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."
Related show

Commit Message

Numan Siddique Sept. 30, 2019, 1:51 p.m. UTC
From: Numan Siddique <nusiddiq@redhat.com>

This partially revers the commit - 298701dbc99645700be41680a43d049cb061847a
as the commit [1] disables the conjunction.

We still need the changes to the tests/ovn.at file.

CC: Han Zhou <hzhou8@ebay.com>
Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
---
 lib/expr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Han Zhou Oct. 1, 2019, 9:24 p.m. UTC | #1
On Mon, Sep 30, 2019 at 6:51 AM <nusiddiq@redhat.com> wrote:
>
> From: Numan Siddique <nusiddiq@redhat.com>
>
> This partially revers the commit -
298701dbc99645700be41680a43d049cb061847a
> as the commit [1] disables the conjunction.
>
> We still need the changes to the tests/ovn.at file.
>
> CC: Han Zhou <hzhou8@ebay.com>
> Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
> ---
>  lib/expr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/expr.c b/lib/expr.c
> index 64ea0aafa..9b9b6bcca 100644
> --- a/lib/expr.c
> +++ b/lib/expr.c
> @@ -1517,7 +1517,7 @@ expr_symtab_add_string(struct shash *symtab, const
char *name,
>      const struct mf_field *field = mf_from_id(id);
>      struct expr_symbol *symbol;
>
> -    symbol = add_symbol(symtab, name, 0, prereqs, EXPR_L_NOMINAL, true,
> +    symbol = add_symbol(symtab, name, 0, prereqs, EXPR_L_NOMINAL, false,
>                          field->writable);
>      symbol->field = field;
>      return symbol;
> --
> 2.21.0
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Thanks Numan.
Acked-by: Han Zhou <hzhou8@ebay.com>
Numan Siddique Oct. 7, 2019, 3:46 p.m. UTC | #2
On Wed, Oct 2, 2019 at 2:54 AM Han Zhou <zhouhan@gmail.com> wrote:

>
>
> On Mon, Sep 30, 2019 at 6:51 AM <nusiddiq@redhat.com> wrote:
> >
> > From: Numan Siddique <nusiddiq@redhat.com>
> >
> > This partially revers the commit -
> 298701dbc99645700be41680a43d049cb061847a
> > as the commit [1] disables the conjunction.
> >
> > We still need the changes to the tests/ovn.at file.
> >
> > CC: Han Zhou <hzhou8@ebay.com>
> > Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
> > ---
> >  lib/expr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/expr.c b/lib/expr.c
> > index 64ea0aafa..9b9b6bcca 100644
> > --- a/lib/expr.c
> > +++ b/lib/expr.c
> > @@ -1517,7 +1517,7 @@ expr_symtab_add_string(struct shash *symtab, const
> char *name,
> >      const struct mf_field *field = mf_from_id(id);
> >      struct expr_symbol *symbol;
> >
> > -    symbol = add_symbol(symtab, name, 0, prereqs, EXPR_L_NOMINAL, true,
> > +    symbol = add_symbol(symtab, name, 0, prereqs, EXPR_L_NOMINAL, false,
> >                          field->writable);
> >      symbol->field = field;
> >      return symbol;
> > --
> > 2.21.0
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> Thanks Numan.
> Acked-by: Han Zhou <hzhou8@ebay.com>
>

Thanks. I applied this to master.

Numan

Patch
diff mbox series

diff --git a/lib/expr.c b/lib/expr.c
index 64ea0aafa..9b9b6bcca 100644
--- a/lib/expr.c
+++ b/lib/expr.c
@@ -1517,7 +1517,7 @@  expr_symtab_add_string(struct shash *symtab, const char *name,
     const struct mf_field *field = mf_from_id(id);
     struct expr_symbol *symbol;
 
-    symbol = add_symbol(symtab, name, 0, prereqs, EXPR_L_NOMINAL, true,
+    symbol = add_symbol(symtab, name, 0, prereqs, EXPR_L_NOMINAL, false,
                         field->writable);
     symbol->field = field;
     return symbol;