From patchwork Sun Sep 29 10:41:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li,Rongqing via dev" X-Patchwork-Id: 1168991 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=openvswitch.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ericsson.com header.i=@ericsson.com header.b="his1zMmH"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46h2M5409Wz9sDB for ; Sun, 29 Sep 2019 20:48:32 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 11767D09; Sun, 29 Sep 2019 10:48:28 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6C9B7CDE for ; Sun, 29 Sep 2019 10:48:26 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20082.outbound.protection.outlook.com [40.107.2.82]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1FE4371C for ; Sun, 29 Sep 2019 10:48:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nklAUtnpzv7O82OYiRrqEDsUatxuRw60/qLoYgkPYoEHEqJZ/WiuWVvy/ZvqI2wZdyZD4Na5zQujK8f65PX1WixyudMY+1E3InoL4FLfkQcL76rsCzQ5KV3qYkdpP8nXuaxnmOW2g7izaZ3JArMwSP2lZrUl7R/F4E+pHsvlIq+G0Tf9Ryxo4+HsaLxVzY5+LGUOuUdNMB7gEHk/pIo0FWvDKK3m0m7JzWADZeSCQk47+EIxXiDu+09yFKqrec3u63Q73W9GijZHH8pd8lYiU57CSV/a2JZ6sreaufDWRYvJT8BfEwPAbBAdHNtfW9/222gy7x28oTgjPFzuqJnGzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zEUE6oRh/7MScittnbTEezpJEsLCrIFZK4cLji8MK8I=; b=oCND6y68AOv34pRgAdbCGjsxyM0JjvNqv8VvjkvYi6dc0/LC3hXFYDm4a0SLvEjxCG4/NZGgtKSqalbFRI5sR7EOy9wgpdFfsdtGsKTuMUUt1NJOWKDyVy/umOy9mbninVVdw+vskin64KTdIozzizJCecgiu9o/+PBmFMX4H5ZAgmTYJvXE2nKoVpP3/x9TlwinQB8jdWQB34P2G0FQZPczsoloS0K3SbNBNhZQ7wHeMfcloWiKv+XAuCWLTwTyLHyMv0d1lU31sAyNLtl636niMru6c6O9GQCrEyk5jSZ3h/XVvoUOOd2K8jDaTvDR9b/vuD49lf/pRld1HeA0ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=ericsson.com; dmarc=pass (p=quarantine sp=none pct=50) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zEUE6oRh/7MScittnbTEezpJEsLCrIFZK4cLji8MK8I=; b=his1zMmHeowltz2bC6lmLmc39g4rOVoUZPnjLdeCogEE7zxWMzt/nD7jb4rjiTsHfnJn13kRXqn0E/jOus5580QCuodIm7QF993xJtIsR8nQ4YIsZZBCNf2ZJLWM3Y7lzsOBv7IzROsAykm0FdqoOPLBcpDkRegh5H/KYFztbgY= Received: from AM4PR07CA0001.eurprd07.prod.outlook.com (2603:10a6:205:1::14) by DB6PR0701MB2981.eurprd07.prod.outlook.com (2603:10a6:4:71::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.15; Sun, 29 Sep 2019 10:48:22 +0000 Received: from HE1EUR02FT029.eop-EUR02.prod.protection.outlook.com (2a01:111:f400:7e05::208) by AM4PR07CA0001.outlook.office365.com (2603:10a6:205:1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.7 via Frontend Transport; Sun, 29 Sep 2019 10:48:22 +0000 Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; openvswitch.org; dkim=none (message not signed) header.d=none;openvswitch.org; dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; Received: from oa.msg.ericsson.com (192.176.1.74) by HE1EUR02FT029.mail.protection.outlook.com (10.152.10.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2305.15 via Frontend Transport; Sun, 29 Sep 2019 10:48:22 +0000 Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSMR502.ericsson.se (153.88.183.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Sun, 29 Sep 2019 12:48:21 +0200 Received: from localhost.localdomain (153.88.183.153) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Sun, 29 Sep 2019 12:48:21 +0200 To: Date: Sun, 29 Sep 2019 16:11:27 +0530 Message-ID: <1569753687-21226-1-git-send-email-vishal.deep.ajmera@ericsson.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [153.88.183.153] X-ClientProxiedBy: ESESSMB502.ericsson.se (153.88.183.163) To ESESSMB501.ericsson.se (153.88.183.162) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.176.1.74; IPV:NLI; CTRY:SE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(376002)(346002)(199004)(189003)(8676002)(48376002)(246002)(6916009)(486006)(6306002)(3846002)(478600001)(5660300002)(126002)(356004)(14444005)(50466002)(6116002)(16526019)(186003)(50226002)(966005)(26005)(2351001)(336012)(16586007)(47776003)(54906003)(476003)(2616005)(4326008)(51416003)(316002)(8936002)(66066001)(2906002)(36756003)(106002)(70206006)(305945005)(956004)(7736002)(70586007)(7636002)(86362001)(386003)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0701MB2981; H:oa.msg.ericsson.com; FPR:; SPF:Pass; LANG:en; PTR:office365.se.ericsson.net; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 007f43c4-c2b3-450e-c76d-08d744ca8c16 X-MS-TrafficTypeDiagnostic: DB6PR0701MB2981: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 017589626D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fSHx2Q/mIqE8RUQcxTL8+2R5bMTPYqeZNAwpoqPVSCIUk+24z/S4LzC0y/VYZDXlrcL9n2nqytioQqqPA8TfPDdtnJC/wIr+sbb+lXaxwGhr57ycODdrUK41s0U5xBqhDb6kLy+3AYJUdSmys/iBz8b6t7MUZ2YB+hEIaaRnmxnObNtOmNmZ3FF+Ajw5b+H9ieMr8WUEs8umScTKi+q85m6IAlW0UPYbbfBWzxYT7oXzZAwvBbe9W3L9qSxSH+jdAKhFHOiy989qk2iAfbvC59cIQpNBkXvtB2ksTXS8p0dUhMcl6WbtQ5cnb/KrNCQ9A0RpoCTnFzPB7yyUrJVlvFYa444bT/1E6kDISKqY8+MLHpM7MwGeCoiGjcJdJfotACMyngJn0rUjBO2/qj+MYK+zd302YaFwL7grjRVcDB8QZA47scAtTed/s17+zjKmjGIGFdblE2Be4bhRWYcDGQ== X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2019 10:48:22.0359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 007f43c4-c2b3-450e-c76d-08d744ca8c16 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2981 X-Spam-Status: No, score=0.1 required=5.0 tests=AC_FROM_MANY_DOTS, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH branch-2.6 v2] conntrack: Fix ICMPv4 error data L4 length check. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vishal Deep Ajmera via dev From: "Li,Rongqing via dev" Reply-To: Vishal Deep Ajmera Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Darrell Ball The ICMPv4 error data L4 length check was found to be too strict for TCP, expecting a minimum of 20 rather than 8 bytes. This worked by hapenstance for other inner protocols. The approach is to explicitly handle the ICMPv4 error data L4 length check and to do this for all supported inner protocols in the same way. Making the code common between protocols also allows the existing ICMPv4 related UDP tests to cover TCP and ICMP inner protocol cases. Note that ICMPv6 does not have an 8 byte limit for error L4 data. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") CC: Daniele Di Proietto Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361949.html Reported-by: Vishal Deep Ajmera Signed-off-by: Vishal Deep Ajmera Co-authored-by: Vishal Deep Ajmera Signed-off-by: Darrell Ball --- lib/conntrack.c | 35 ++++++++++++++++++++--------------- lib/packets.h | 3 +++ 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 8abaf7e..d59083e 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -664,11 +664,12 @@ check_l4_icmp6(const struct conn_key *key, const void *data, size_t size, } static inline bool -extract_l4_tcp(struct conn_key *key, const void *data, size_t size) +extract_l4_tcp(struct conn_key *key, const void *data, size_t size, + size_t *chk_len) { const struct tcp_header *tcp = data; - if (OVS_UNLIKELY(size < TCP_HEADER_LEN)) { + if (OVS_UNLIKELY(size < (chk_len ? *chk_len : TCP_HEADER_LEN))) { return false; } @@ -680,11 +681,12 @@ extract_l4_tcp(struct conn_key *key, const void *data, size_t size) } static inline bool -extract_l4_udp(struct conn_key *key, const void *data, size_t size) +extract_l4_udp(struct conn_key *key, const void *data, size_t size, + size_t *chk_len) { const struct udp_header *udp = data; - if (OVS_UNLIKELY(size < UDP_HEADER_LEN)) { + if (OVS_UNLIKELY(size < (chk_len ? *chk_len : UDP_HEADER_LEN))) { return false; } @@ -696,7 +698,8 @@ extract_l4_udp(struct conn_key *key, const void *data, size_t size) } static inline bool extract_l4(struct conn_key *key, const void *data, - size_t size, bool *related, const void *l3); + size_t size, bool *related, const void *l3, + size_t *chk_len); static uint8_t reverse_icmp_type(uint8_t type) @@ -728,11 +731,11 @@ reverse_icmp_type(uint8_t type) * possible */ static inline int extract_l4_icmp(struct conn_key *key, const void *data, size_t size, - bool *related) + bool *related, size_t *chk_len) { const struct icmp_header *icmp = data; - if (OVS_UNLIKELY(size < ICMP_HEADER_LEN)) { + if (OVS_UNLIKELY(size < (chk_len ? *chk_len : ICMP_HEADER_LEN))) { return false; } @@ -783,8 +786,9 @@ extract_l4_icmp(struct conn_key *key, const void *data, size_t size, key->src = inner_key.src; key->dst = inner_key.dst; key->nw_proto = inner_key.nw_proto; + size_t check_len = ICMP_ERROR_DATA_L4_LEN; - ok = extract_l4(key, l4, tail - l4, NULL, l3); + ok = extract_l4(key, l4, tail - l4, NULL, l3, &check_len); if (ok) { conn_key_reverse(key); *related = true; @@ -872,7 +876,7 @@ extract_l4_icmp6(struct conn_key *key, const void *data, size_t size, key->dst = inner_key.dst; key->nw_proto = inner_key.nw_proto; - ok = extract_l4(key, l4, tail - l4, NULL, l3); + ok = extract_l4(key, l4, tail - l4, NULL, l3, NULL); if (ok) { conn_key_reverse(key); *related = true; @@ -897,21 +901,22 @@ extract_l4_icmp6(struct conn_key *key, const void *data, size_t size, * an ICMP or ICMP6 header. * * * If 'related' is NULL, it means that we're already parsing a header nested - * in an ICMP error. In this case, we skip checksum and length validation. */ + * in an ICMP error. In this case, we skip the checksum and some length + * validations. */ static inline bool extract_l4(struct conn_key *key, const void *data, size_t size, bool *related, - const void *l3) + const void *l3, size_t *chk_len) { if (key->nw_proto == IPPROTO_TCP) { return (!related || check_l4_tcp(key, data, size, l3)) - && extract_l4_tcp(key, data, size); + && extract_l4_tcp(key, data, size, chk_len); } else if (key->nw_proto == IPPROTO_UDP) { return (!related || check_l4_udp(key, data, size, l3)) - && extract_l4_udp(key, data, size); + && extract_l4_udp(key, data, size, chk_len); } else if (key->dl_type == htons(ETH_TYPE_IP) && key->nw_proto == IPPROTO_ICMP) { return (!related || check_l4_icmp(data, size)) - && extract_l4_icmp(key, data, size, related); + && extract_l4_icmp(key, data, size, related, chk_len); } else if (key->dl_type == htons(ETH_TYPE_IPV6) && key->nw_proto == IPPROTO_ICMPV6) { return (!related || check_l4_icmp6(key, data, size, l3)) @@ -982,7 +987,7 @@ conn_key_extract(struct conntrack *ct, struct dp_packet *pkt, ovs_be16 dl_type, if (ok) { if (extract_l4(&ctx->key, l4, dp_packet_l4_size(pkt), - &ctx->related, l3)) { + &ctx->related, l3, NULL)) { ctx->hash = conn_key_hash(&ctx->key, ct->hash_basis); return true; } diff --git a/lib/packets.h b/lib/packets.h index 0705576..adfa86c 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -656,6 +656,9 @@ struct icmp_header { }; BUILD_ASSERT_DECL(ICMP_HEADER_LEN == sizeof(struct icmp_header)); +/* ICMPV4 */ +#define ICMP_ERROR_DATA_L4_LEN 8 + #define IGMP_HEADER_LEN 8 struct igmp_header { uint8_t igmp_type;