| Message ID | 20190927112703.17745-10-sgarzare@redhat.com |
|---|---|
| State | RFC |
| Delegated to: | David Miller |
| Headers | show |
| Series | vsock: add multi-transports support | expand |
> From: Stefano Garzarella <sgarzare@redhat.com> > Sent: Friday, September 27, 2019 4:27 AM > To: netdev@vger.kernel.org > Cc: linux-hyperv@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Stefan > Hajnoczi <stefanha@redhat.com>; Sasha Levin <sashal@kernel.org>; > linux-kernel@vger.kernel.org; kvm@vger.kernel.org; David S. Miller > <davem@davemloft.net>; virtualization@lists.linux-foundation.org; Stephen > Hemminger <sthemmin@microsoft.com>; Jason Wang > <jasowang@redhat.com>; Michael S. Tsirkin <mst@redhat.com>; Haiyang > Zhang <haiyangz@microsoft.com>; Dexuan Cui <decui@microsoft.com>; > Jorgen Hansen <jhansen@vmware.com> > Subject: [RFC PATCH 09/13] hv_sock: set VMADDR_CID_HOST in the > hvs_remote_addr_init() > > Remote peer is always the host, so we set VMADDR_CID_HOST as > remote CID instead of VMADDR_CID_ANY. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > net/vmw_vsock/hyperv_transport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/hyperv_transport.c > b/net/vmw_vsock/hyperv_transport.c > index 4f47af2054dd..306310794522 100644 > --- a/net/vmw_vsock/hyperv_transport.c > +++ b/net/vmw_vsock/hyperv_transport.c > @@ -186,7 +186,8 @@ static void hvs_remote_addr_init(struct sockaddr_vm > *remote, > static u32 host_ephemeral_port = MIN_HOST_EPHEMERAL_PORT; > struct sock *sk; > > - vsock_addr_init(remote, VMADDR_CID_ANY, VMADDR_PORT_ANY); > + /* Remote peer is always the host */ > + vsock_addr_init(remote, VMADDR_CID_HOST, VMADDR_PORT_ANY); > > while (1) { > /* Wrap around ? */ > -- Looks good to me, since hv_sock doesn't really use the CID in the transport layer. Reviewed-by: Dexuan Cui <decui@microsoft.com>
On Fri, Sep 27, 2019 at 01:26:59PM +0200, Stefano Garzarella wrote: > Remote peer is always the host, so we set VMADDR_CID_HOST as > remote CID instead of VMADDR_CID_ANY. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > net/vmw_vsock/hyperv_transport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c index 4f47af2054dd..306310794522 100644 --- a/net/vmw_vsock/hyperv_transport.c +++ b/net/vmw_vsock/hyperv_transport.c @@ -186,7 +186,8 @@ static void hvs_remote_addr_init(struct sockaddr_vm *remote, static u32 host_ephemeral_port = MIN_HOST_EPHEMERAL_PORT; struct sock *sk; - vsock_addr_init(remote, VMADDR_CID_ANY, VMADDR_PORT_ANY); + /* Remote peer is always the host */ + vsock_addr_init(remote, VMADDR_CID_HOST, VMADDR_PORT_ANY); while (1) { /* Wrap around ? */
Remote peer is always the host, so we set VMADDR_CID_HOST as remote CID instead of VMADDR_CID_ANY. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> --- net/vmw_vsock/hyperv_transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)