[ovs-dev] configure: Properly handle case where sphinx-build is not available.
diff mbox series

Message ID 20190920190016.9178-1-blp@ovn.org
State New
Headers show
Series
  • [ovs-dev] configure: Properly handle case where sphinx-build is not available.
Related show

Commit Message

Ben Pfaff Sept. 20, 2019, 7 p.m. UTC
Reported-by: Justin Pettit <jpettit@ovn.org>
Fixes: ab4514890587 ("Recommend Sphinx from Python 3 in documentation and packaging.")
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 m4/openvswitch.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Justin Pettit Sept. 21, 2019, 12:34 a.m. UTC | #1
> On Sep 20, 2019, at 12:00 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> Reported-by: Justin Pettit <jpettit@ovn.org>
> Fixes: ab4514890587 ("Recommend Sphinx from Python 3 in documentation and packaging.")
> Signed-off-by: Ben Pfaff <blp@ovn.org>

Acked-by: Justin Pettit <jpettit@ovn.org>

--Justin
Ben Pfaff Sept. 21, 2019, 12:39 a.m. UTC | #2
On Fri, Sep 20, 2019 at 05:34:29PM -0700, Justin Pettit wrote:
> 
> > On Sep 20, 2019, at 12:00 PM, Ben Pfaff <blp@ovn.org> wrote:
> > 
> > Reported-by: Justin Pettit <jpettit@ovn.org>
> > Fixes: ab4514890587 ("Recommend Sphinx from Python 3 in documentation and packaging.")
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> Acked-by: Justin Pettit <jpettit@ovn.org>

Thanks, and sorry for causing the problem.  I applied this to master.

Patch
diff mbox series

diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
index 50edd555052e..78d70fb4e17e 100644
--- a/m4/openvswitch.m4
+++ b/m4/openvswitch.m4
@@ -414,7 +414,7 @@  AC_DEFUN([OVS_CHECK_SPHINX],
   [AC_CHECK_PROGS(
      [SPHINXBUILD], [sphinx-build-3 sphinx-build-2 sphinx-build], [none])
    AC_ARG_VAR([SPHINXBUILD])
-   AM_CONDITIONAL([HAVE_SPHINX], [test "$ac_cv_prog_SPHINXBUILD" != none])])
+   AM_CONDITIONAL([HAVE_SPHINX], [test "$SPHINXBUILD" != none])])
 
 dnl Checks for dot.
 AC_DEFUN([OVS_CHECK_DOT],