| Message ID | 20190920113003.21711-1-peter@korsgaard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/joe: license is GPL-2.0+ | expand |
Hi Peter, On Fri, Sep 20, 2019 at 1:30 PM Peter Korsgaard <peter@korsgaard.com> wrote: > > Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development > leading up to 3.8: > > https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ > > So change the license to GPL-2.0+ GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1]. What should we do? Should we switch to the new ones? [1] https://spdx.org/licenses/GPL-2.0+.html Yegor > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> > --- > package/joe/joe.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/joe/joe.mk b/package/joe/joe.mk > index 9a3215c4e1..f0cac402e1 100644 > --- a/package/joe/joe.mk > +++ b/package/joe/joe.mk > @@ -6,7 +6,7 @@ > > JOE_VERSION = 4.6 > JOE_SITE = http://downloads.sourceforge.net/project/joe-editor/JOE%20sources/joe-$(JOE_VERSION) > -JOE_LICENSE = GPL-1.0+ > +JOE_LICENSE = GPL-2.0+ > JOE_LICENSE_FILES = COPYING > > ifeq ($(BR2_PACKAGE_NCURSES),y) > -- > 2.20.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On Fri, 20 Sep 2019 13:36:48 +0200 Yegor Yefremov <yegorslists@googlemail.com> wrote: > Hi Peter, > > On Fri, Sep 20, 2019 at 1:30 PM Peter Korsgaard <peter@korsgaard.com> wrote: > > > > Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development > > leading up to 3.8: > > > > https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ > > > > So change the license to GPL-2.0+ > > GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1]. I was aware of GPL-2.0+ being deprecated, but not GPL-2.0. And indeed SPDX now uses GPL-2.0-or-later (instead of GPL-2.0+) and GPL-2.0-only (instead of GPL-2.0). > What should we do? Should we switch to the new ones? Ideally yes, to follow SPDX. However, there are a few gotchas: - The number of packages that need to be changed (though that's easily doable with sed) - The potential backward compatibility breakage. If people have scripts/tools that parses our manifest.csv and interpret the license values, the renaming might break for them. But maybe these are not that important, and sticking to SPDX is mort important ? Anyway, that's a separate discussion from Peter's patch. Peter's patch is fine as-is, as it matches the current practice in Buildroot. Thomas
>>>>> "Yegor" == Yegor Yefremov <yegorslists@googlemail.com> writes: > Hi Peter, > On Fri, Sep 20, 2019 at 1:30 PM Peter Korsgaard <peter@korsgaard.com> wrote: >> >> Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development >> leading up to 3.8: >> >> https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ >> >> So change the license to GPL-2.0+ > GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1]. > What should we do? Should we switch to the new ones? > [1] https://spdx.org/licenses/GPL-2.0+.html That is a bigger discussion. I personally find the replacement "(GNU General Public License v2.0 only) or later" harder to read: https://lists.denx.de/pipermail/u-boot/2015-August/223991.html Are there any concrete advantages to changing this tree wide?
On Fri, 20 Sep 2019 13:56:20 +0200 Peter Korsgaard <peter@korsgaard.com> wrote: > >>>>> "Yegor" == Yegor Yefremov <yegorslists@googlemail.com> writes: > > > Hi Peter, > > On Fri, Sep 20, 2019 at 1:30 PM Peter Korsgaard <peter@korsgaard.com> wrote: > >> > >> Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development > >> leading up to 3.8: > >> > >> https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ > >> > >> So change the license to GPL-2.0+ > > > GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1]. > > > What should we do? Should we switch to the new ones? > > > [1] https://spdx.org/licenses/GPL-2.0+.html > > That is a bigger discussion. I personally find the replacement > "(GNU General Public License v2.0 only) or later" harder to read: > > https://lists.denx.de/pipermail/u-boot/2015-August/223991.html > > Are there any concrete advantages to changing this tree wide? The replacement is GPL-2.0-or-later, see https://spdx.org/licenses/. I'm not sure where they got this "(GNU General Public License v2.0 only) or later" in the U-Boot discussion. Thomas
On 20/09/2019 13:30, Peter Korsgaard wrote: > Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development > leading up to 3.8: > > https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ > > So change the license to GPL-2.0+ > > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Applied to master, thanks. As noted in the thread, changing GPL-2.0+ to GPL-2.0-or-later is a separate issue. Regards, Arnout > --- > package/joe/joe.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/joe/joe.mk b/package/joe/joe.mk > index 9a3215c4e1..f0cac402e1 100644 > --- a/package/joe/joe.mk > +++ b/package/joe/joe.mk > @@ -6,7 +6,7 @@ > > JOE_VERSION = 4.6 > JOE_SITE = http://downloads.sourceforge.net/project/joe-editor/JOE%20sources/joe-$(JOE_VERSION) > -JOE_LICENSE = GPL-1.0+ > +JOE_LICENSE = GPL-2.0+ > JOE_LICENSE_FILES = COPYING > > ifeq ($(BR2_PACKAGE_NCURSES),y) >
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: > Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development > leading up to 3.8: > https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ > So change the license to GPL-2.0+ > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.
diff --git a/package/joe/joe.mk b/package/joe/joe.mk index 9a3215c4e1..f0cac402e1 100644 --- a/package/joe/joe.mk +++ b/package/joe/joe.mk @@ -6,7 +6,7 @@ JOE_VERSION = 4.6 JOE_SITE = http://downloads.sourceforge.net/project/joe-editor/JOE%20sources/joe-$(JOE_VERSION) -JOE_LICENSE = GPL-1.0+ +JOE_LICENSE = GPL-2.0+ JOE_LICENSE_FILES = COPYING ifeq ($(BR2_PACKAGE_NCURSES),y)
Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8: https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/ So change the license to GPL-2.0+ Signed-off-by: Peter Korsgaard <peter@korsgaard.com> --- package/joe/joe.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)