[ovs-dev] ovs-bugtool: Add ip -s -s to get_device_stats.out.
diff mbox series

Message ID 1568308065-124041-1-git-send-email-u9012063@gmail.com
State New
Headers show
Series
  • [ovs-dev] ovs-bugtool: Add ip -s -s to get_device_stats.out.
Related show

Commit Message

William Tu Sept. 12, 2019, 5:07 p.m. UTC
The patch adds 'ip -s -s' to file get_device_stats.out to collect
device statistics. When debugging tunnel related issues, the command
shows much more detailed counters, ex: frame, crc, carrier, helping
to understand the root cause when packets are dropped.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 utilities/bugtool/plugins/network-status/openvswitch.xml | 1 +
 1 file changed, 1 insertion(+)

Comments

0-day Robot Sept. 12, 2019, 5:59 p.m. UTC | #1
Bleep bloop.  Greetings William Tu, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#24 FILE: utilities/bugtool/plugins/network-status/openvswitch.xml:43:
    <command label="get_device_stats" filters="ovs">ip -s -s link show</command>

Lines checked: 28, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
William Tu Sept. 12, 2019, 6:07 p.m. UTC | #2
On Thu, Sep 12, 2019 at 11:01 AM 0-day Robot <robot@bytheb.org> wrote:
>
> Bleep bloop.  Greetings William Tu, I am a robot and I have tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> checkpatch:
> WARNING: Line is 80 characters long (recommended limit is 79)
> #24 FILE: utilities/bugtool/plugins/network-status/openvswitch.xml:43:
>     <command label="get_device_stats" filters="ovs">ip -s -s link show</command>
>
This is xml file and I think it's OK for more than 79 char.
I will submit a patch to skip checking for utilities/bugtool/

Thanks
William
Gregory Rose Sept. 16, 2019, 4:31 p.m. UTC | #3
On 9/12/2019 10:07 AM, William Tu wrote:
> The patch adds 'ip -s -s' to file get_device_stats.out to collect
> device statistics. When debugging tunnel related issues, the command
> shows much more detailed counters, ex: frame, crc, carrier, helping
> to understand the root cause when packets are dropped.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>   utilities/bugtool/plugins/network-status/openvswitch.xml | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml
> index d39867c6e4d0..b0e7a15103b0 100644
> --- a/utilities/bugtool/plugins/network-status/openvswitch.xml
> +++ b/utilities/bugtool/plugins/network-status/openvswitch.xml
> @@ -40,4 +40,5 @@
>       <command label="ovs-ofctl-dump-groups" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "dump-groups"</command>
>       <command label="ovs-ofctl-dump-group-stats" filters="ovs" repeat="2">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "dump-group-stats"</command>
>       <command label="get_dpdk_nic_numa" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-get-dpdk-nic-numa</command>
> +    <command label="get_device_stats" filters="ovs">ip -s -s link show</command>
>   </collect>

LGTM

Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Ben Pfaff Sept. 18, 2019, 4:28 p.m. UTC | #4
On Mon, Sep 16, 2019 at 09:31:36AM -0700, Gregory Rose wrote:
> 
> On 9/12/2019 10:07 AM, William Tu wrote:
> > The patch adds 'ip -s -s' to file get_device_stats.out to collect
> > device statistics. When debugging tunnel related issues, the command
> > shows much more detailed counters, ex: frame, crc, carrier, helping
> > to understand the root cause when packets are dropped.
> > 
> > Signed-off-by: William Tu <u9012063@gmail.com>
> > ---
> >   utilities/bugtool/plugins/network-status/openvswitch.xml | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml
> > index d39867c6e4d0..b0e7a15103b0 100644
> > --- a/utilities/bugtool/plugins/network-status/openvswitch.xml
> > +++ b/utilities/bugtool/plugins/network-status/openvswitch.xml
> > @@ -40,4 +40,5 @@
> >       <command label="ovs-ofctl-dump-groups" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "dump-groups"</command>
> >       <command label="ovs-ofctl-dump-group-stats" filters="ovs" repeat="2">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "dump-group-stats"</command>
> >       <command label="get_dpdk_nic_numa" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-get-dpdk-nic-numa</command>
> > +    <command label="get_device_stats" filters="ovs">ip -s -s link show</command>
> >   </collect>
> 
> LGTM
> 
> Reviewed-by: Greg Rose <gvrose8192@gmail.com>

Thanks, applied to master.

Patch
diff mbox series

diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml
index d39867c6e4d0..b0e7a15103b0 100644
--- a/utilities/bugtool/plugins/network-status/openvswitch.xml
+++ b/utilities/bugtool/plugins/network-status/openvswitch.xml
@@ -40,4 +40,5 @@ 
     <command label="ovs-ofctl-dump-groups" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "dump-groups"</command>
     <command label="ovs-ofctl-dump-group-stats" filters="ovs" repeat="2">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "dump-group-stats"</command>
     <command label="get_dpdk_nic_numa" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-get-dpdk-nic-numa</command>
+    <command label="get_device_stats" filters="ovs">ip -s -s link show</command>
 </collect>