| Message ID | c86b291ccbaccefe519f95702d4e6133351570dc.1568190772.git.echaudro@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] vswitchd: update bond-rebalance-interval maxInteger in vswtich.xml | expand |
On Wed, Sep 11, 2019 at 10:33:57AM +0200, Eelco Chaudron wrote: > According to the documentation in the vswtich.xml the maximum > configurable bond-rebalance-interval is 10000ms. However, this is not > enforced anywhere in the code and people are using larger values in > the field. > > To avoid confusion this change changes the maximum value the > 2147483647 which will fit in 32bit integer. This will allow a value of > ~25 days, which should be enough to cover everybody's needs. Note that > a value of 0 disables the automatic rebalancing anyway. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Thanks! Applied to master.
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 9a743c05b..26e60fb19 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -2098,7 +2098,8 @@ </p> <column name="other_config" key="bond-rebalance-interval" - type='{"type": "integer", "minInteger": 0, "maxInteger": 10000}'> + type='{"type": "integer", + "minInteger": 0, "maxInteger": 2147483647}'> For a load balanced bonded port, the number of milliseconds between successive attempts to rebalance the bond, that is, to move flows from one interface on the bond to another in an attempt to keep usage
According to the documentation in the vswtich.xml the maximum configurable bond-rebalance-interval is 10000ms. However, this is not enforced anywhere in the code and people are using larger values in the field. To avoid confusion this change changes the maximum value the 2147483647 which will fit in 32bit integer. This will allow a value of ~25 days, which should be enough to cover everybody's needs. Note that a value of 0 disables the automatic rebalancing anyway. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- vswitchd/vswitch.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)