[ovs-dev] ovn: Fix broken dist* targets.
diff mbox series

Message ID 20190910080142.25736-1-i.maximets@samsung.com
State Accepted
Headers show
Series
  • [ovs-dev] ovn: Fix broken dist* targets.
Related show

Commit Message

Ilya Maximets Sept. 10, 2019, 8:01 a.m. UTC
Redundant line continuation was missed while removing OVN
that broke distdir target and subsequently all the dependent
targets, e.g. distcheck:

  make[1]:
  *** No rule to make target 'nodist_ovn_lib_libovn_la_SOURCES',
      needed by 'distdir'.  Stop.

CC: Mark Michelson <mmichels@redhat.com>
Fixes: f3e24610ea18 ("Remove OVN.")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 ovn/lib/automake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ilya Maximets Sept. 11, 2019, 11:10 a.m. UTC | #1
Kind reminder.

This fix is important, because the issue breaks all the testsuite
targets in TravisCI. It'll be good to make it work.

Best regards, Ilya Maximets.

On 10.09.2019 11:01, Ilya Maximets wrote:
> Redundant line continuation was missed while removing OVN
> that broke distdir target and subsequently all the dependent
> targets, e.g. distcheck:
> 
>   make[1]:
>   *** No rule to make target 'nodist_ovn_lib_libovn_la_SOURCES',
>       needed by 'distdir'.  Stop.
> 
> CC: Mark Michelson <mmichels@redhat.com>
> Fixes: f3e24610ea18 ("Remove OVN.")
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>  ovn/lib/automake.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovn/lib/automake.mk b/ovn/lib/automake.mk
> index c74430005..53a10e211 100644
> --- a/ovn/lib/automake.mk
> +++ b/ovn/lib/automake.mk
> @@ -7,7 +7,7 @@ ovn_lib_libovn_la_SOURCES = \
>  	ovn/lib/acl-log.c \
>  	ovn/lib/acl-log.h \
>  	ovn/lib/ovn-util.c \
> -	ovn/lib/ovn-util.h \
> +	ovn/lib/ovn-util.h
>  nodist_ovn_lib_libovn_la_SOURCES = \
>  	ovn/lib/ovn-nb-idl.c \
>  	ovn/lib/ovn-nb-idl.h \
>
Numan Siddique Sept. 11, 2019, 11:31 a.m. UTC | #2
On Tue, Sep 10, 2019 at 1:31 PM Ilya Maximets <i.maximets@samsung.com>
wrote:

> Redundant line continuation was missed while removing OVN
> that broke distdir target and subsequently all the dependent
> targets, e.g. distcheck:
>
>   make[1]:
>   *** No rule to make target 'nodist_ovn_lib_libovn_la_SOURCES',
>       needed by 'distdir'.  Stop.
>
> CC: Mark Michelson <mmichels@redhat.com>
> Fixes: f3e24610ea18 ("Remove OVN.")
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
>

Acked-by: Numan Siddique <nusiddiq@redhat.com>

There's another cleanup patch if you would like to take a look -
https://patchwork.ozlabs.org/patch/1160181/

Thanks
Numan


> ---
>  ovn/lib/automake.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/lib/automake.mk b/ovn/lib/automake.mk
> index c74430005..53a10e211 100644
> --- a/ovn/lib/automake.mk
> +++ b/ovn/lib/automake.mk
> @@ -7,7 +7,7 @@ ovn_lib_libovn_la_SOURCES = \
>         ovn/lib/acl-log.c \
>         ovn/lib/acl-log.h \
>         ovn/lib/ovn-util.c \
> -       ovn/lib/ovn-util.h \
> +       ovn/lib/ovn-util.h
>  nodist_ovn_lib_libovn_la_SOURCES = \
>         ovn/lib/ovn-nb-idl.c \
>         ovn/lib/ovn-nb-idl.h \
> --
> 2.17.1
>
>
Ilya Maximets Sept. 11, 2019, 1:41 p.m. UTC | #3
On 11.09.2019 14:31, Numan Siddique wrote:
> 
> 
> On Tue, Sep 10, 2019 at 1:31 PM Ilya Maximets <i.maximets@samsung.com <mailto:i.maximets@samsung.com>> wrote:
> 
>     Redundant line continuation was missed while removing OVN
>     that broke distdir target and subsequently all the dependent
>     targets, e.g. distcheck:
> 
>       make[1]:
>       *** No rule to make target 'nodist_ovn_lib_libovn_la_SOURCES',
>           needed by 'distdir'.  Stop.
> 
>     CC: Mark Michelson <mmichels@redhat.com <mailto:mmichels@redhat.com>>
>     Fixes: f3e24610ea18 ("Remove OVN.")
>     Signed-off-by: Ilya Maximets <i.maximets@samsung.com <mailto:i.maximets@samsung.com>>
> 
> 
> Acked-by: Numan Siddique <nusiddiq@redhat.com <mailto:nusiddiq@redhat.com>>

Thanks! Applied to master.

Best regards, Ilya Maximets.

Patch
diff mbox series

diff --git a/ovn/lib/automake.mk b/ovn/lib/automake.mk
index c74430005..53a10e211 100644
--- a/ovn/lib/automake.mk
+++ b/ovn/lib/automake.mk
@@ -7,7 +7,7 @@  ovn_lib_libovn_la_SOURCES = \
 	ovn/lib/acl-log.c \
 	ovn/lib/acl-log.h \
 	ovn/lib/ovn-util.c \
-	ovn/lib/ovn-util.h \
+	ovn/lib/ovn-util.h
 nodist_ovn_lib_libovn_la_SOURCES = \
 	ovn/lib/ovn-nb-idl.c \
 	ovn/lib/ovn-nb-idl.h \