[ovs-dev,v1,2.12] OVN: Repair memory leak for OVN controller events.
diff mbox series

Message ID 20190829180427.27901-1-mmichels@redhat.com
State New
Headers show
Series
  • [ovs-dev,v1,2.12] OVN: Repair memory leak for OVN controller events.
Related show

Commit Message

Mark Michelson Aug. 29, 2019, 6:04 p.m. UTC
Controller event action is leaking its genopts. This corrects the error.

Signed-off-by: Mark Michelson <mmichels@redhat.com>
---
v1 -> v2 Added Signoff
---
 ovn/lib/actions.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ben Pfaff Aug. 29, 2019, 6:16 p.m. UTC | #1
On Thu, Aug 29, 2019 at 02:04:27PM -0400, Mark Michelson wrote:
> Controller event action is leaking its genopts. This corrects the error.
> 
> Signed-off-by: Mark Michelson <mmichels@redhat.com>
> ---
> v1 -> v2 Added Signoff

It seems that I must have screwed up and applied this a number of
commits ago without the sign-off.  Oops.  It is not worth changing the
history to add the sign-off at this point.  I apologize, though.

Patch
diff mbox series

diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c
index b0cb3490b..274297194 100644
--- a/ovn/lib/actions.c
+++ b/ovn/lib/actions.c
@@ -1760,8 +1760,9 @@  parse_trigger_event(struct action_context *ctx,
 }
 
 static void
-ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED)
+ovnact_controller_event_free(struct ovnact_controller_event *event)
 {
+    free_gen_options(event->options, event->n_options);
 }
 
 static void