[ovs-dev,2.9,2.8,2.7] tests: fix output indentation in tunnel.at
diff mbox series

Message ID 20190829033608.16794-1-fbl@sysclose.org
State New
Headers show
Series
  • [ovs-dev,2.9,2.8,2.7] tests: fix output indentation in tunnel.at
Related show

Commit Message

Vishal Deep Ajmera via dev Aug. 29, 2019, 3:36 a.m. UTC
The commit b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
uses the output indentation from newer OvS versions which include the
commit 7be29a47576d ("ofproto-dpif: Remove tabs from output.").

Fixes: b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
Signed-off-by: Flavio Leitner <fbl@sysclose.org>
---
 tests/tunnel.at | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

0-day Robot Aug. 29, 2019, 3:58 a.m. UTC | #1
Bleep bloop.  Greetings Flavio Leitner via dev, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


build:
    -e 's,[@]PYTHON[@],/bin/python2,g' \
    -e 's,[@]RUNDIR[@],/usr/local/var/run/openvswitch,g' \
    -e 's,[@]VERSION[@],2.12.90,g' \
    -e 's,[@]localstatedir[@],/usr/local/var,g' \
    -e 's,[@]pkgdatadir[@],/usr/local/share/openvswitch,g' \
    -e 's,[@]sysconfdir[@],/usr/local/etc,g' \
    -e 's,[@]bindir[@],/usr/local/bin,g' \
    -e 's,[@]sbindir[@],/usr/local/sbin,g' \
    -e 's,[@]abs_builddir[@],/var/lib/jenkins/jobs/upstream_build_from_pw/workspace,g' \
    -e 's,[@]abs_top_srcdir[@],/var/lib/jenkins/jobs/upstream_build_from_pw/workspace,g' \
  > rhel/ovn-fedora.spec.tmp
mv rhel/ovn-fedora.spec.tmp rhel/ovn-fedora.spec
(printf '\043 Generated automatically -- do not modify!    -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.12.90,g') \
	< ./xenserver/openvswitch-xen.spec.in > openvswitch-xen.spec.tmp || exit 1; \
if cmp -s openvswitch-xen.spec.tmp xenserver/openvswitch-xen.spec; then touch xenserver/openvswitch-xen.spec; rm openvswitch-xen.spec.tmp; else mv openvswitch-xen.spec.tmp xenserver/openvswitch-xen.spec; fi
make[3]: Entering directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath'
make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath'
tests/tunnel.at
See above for files that use tabs for indentation.
Please use spaces instead.
make[2]: *** [check-tabs] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Ben Pfaff Aug. 29, 2019, 4:04 a.m. UTC | #2
On Thu, Aug 29, 2019 at 12:36:08AM -0300, Flavio Leitner via dev wrote:
> The commit b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
> uses the output indentation from newer OvS versions which include the
> commit 7be29a47576d ("ofproto-dpif: Remove tabs from output.").
> 
> Fixes: b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
> Signed-off-by: Flavio Leitner <fbl@sysclose.org>

Applied to 2.9, 2.8, 2.7, thanks!

Patch
diff mbox series

diff --git a/tests/tunnel.at b/tests/tunnel.at
index fd9fe04b6..38f7f48d8 100644
--- a/tests/tunnel.at
+++ b/tests/tunnel.at
@@ -408,13 +408,13 @@  AT_CHECK([ovs-vsctl add-port int-br v1 -- set Interface v1 type=vxlan \
 
 AT_CHECK([ovs-appctl dpif/show], [0], [dnl
 dummy@ovs-dummy: hit:0 missed:0
-  br0:
-    br0 65534/100: (dummy-internal)
-    p0 1/1: (dummy)
-  int-br:
-    int-br 65534/2: (dummy-internal)
-    v1 2/4789: (vxlan: key=123, remote_ip=172.31.1.2)
-    v2 3/3: (dummy-internal)
+	br0:
+		br0 65534/100: (dummy-internal)
+		p0 1/1: (dummy)
+	int-br:
+		int-br 65534/2: (dummy-internal)
+		v1 2/4789: (vxlan: key=123, remote_ip=172.31.1.2)
+		v2 3/3: (dummy-internal)
 ])
 
 dnl First setup dummy interface IP address, then add the route