| Message ID | 1566929353-22329-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,PATCHv2] ovs-lib: Add timeout at ovs-check-dead-ifs. | expand |
On Tue, 27 Aug 2019 at 11:10, William Tu <u9012063@gmail.com> wrote: > At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read > an entry in /proc/<pid>/fd/<some fd> but hangs forever. The pid is > a qemu-system-x86_64 process and we suspect it's an issue related to > qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge > never gets restarted. This patch adds a timeout of 5-seconds to > ovs-check-dead-ifs. > > VMware-BZ: #2408059 > Signed-off-by: William Tu <u9012063@gmail.com> > Cc: Ashish Varma <ashishvarma.ovs@gmail.com> > Cc: Gurucharan Shetty <guru@ovn.org> > --- > v2: address feedback from Guru > --- > Thanks. I applied this to master, 2.12 and 2.11 > utilities/ovs-lib.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in > index 76ce79b9c39f..c8c09dd12d31 100644 > --- a/utilities/ovs-lib.in > +++ b/utilities/ovs-lib.in > @@ -654,7 +654,8 @@ force_reload_kmod () { > > restore_interfaces > > - "$datadir/scripts/ovs-check-dead-ifs" > + action "Finding processes on dead interfaces" timeout 5 \ > + "$datadir/scripts/ovs-check-dead-ifs" || true > } > > ## ------- ## > -- > 2.7.4 > >
diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index 76ce79b9c39f..c8c09dd12d31 100644 --- a/utilities/ovs-lib.in +++ b/utilities/ovs-lib.in @@ -654,7 +654,8 @@ force_reload_kmod () { restore_interfaces - "$datadir/scripts/ovs-check-dead-ifs" + action "Finding processes on dead interfaces" timeout 5 \ + "$datadir/scripts/ovs-check-dead-ifs" || true } ## ------- ##
At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read an entry in /proc/<pid>/fd/<some fd> but hangs forever. The pid is a qemu-system-x86_64 process and we suspect it's an issue related to qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge never gets restarted. This patch adds a timeout of 5-seconds to ovs-check-dead-ifs. VMware-BZ: #2408059 Signed-off-by: William Tu <u9012063@gmail.com> Cc: Ashish Varma <ashishvarma.ovs@gmail.com> Cc: Gurucharan Shetty <guru@ovn.org> --- v2: address feedback from Guru --- utilities/ovs-lib.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)