diff mbox series

[ovs-dev,ovn,1/2] northd: introduce build_empty_lb_event_flow routine

Message ID ebca4487fa74bf64365a31811b266f4ecee73631.1566919076.git.lorenzo.bianconi@redhat.com
State Superseded
Headers show
Series add empty_lb controller_event for logical router pipeline | expand

Commit Message

Lorenzo Bianconi Aug. 27, 2019, 3:25 p.m. UTC 
Introduce build_empty_lb_event_flow routine and remove open code

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 northd/ovn-northd.c | 63 ++++++++++++++++++++++++++-------------------
 1 file changed, 37 insertions(+), 26 deletions(-)
diff mbox series

Patch

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index ca128c996..9db8b43e2 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -4001,6 +4001,41 @@  ls_has_dns_records(const struct nbrec_logical_switch *nbs)
     return false;
 }
 
+static void
+build_empty_lb_event_flow(struct ovn_datapath *od, struct hmap *lflows,
+                          struct smap_node *node, char *ip_address,
+                          struct nbrec_load_balancer *lb, uint16_t port,
+                          int addr_family, int pl)
+{
+    if (!controller_event_en || node->value[0]) {
+        return;
+    }
+
+    struct ds match = DS_EMPTY_INITIALIZER;
+    char *action;
+
+    if (addr_family == AF_INET) {
+        ds_put_format(&match, "ip4.dst == %s && %s",
+                      ip_address, lb->protocol);
+    } else {
+        ds_put_format(&match, "ip6.dst == %s && %s",
+                      ip_address, lb->protocol);
+    }
+    if (port) {
+        ds_put_format(&match, " && %s.dst == %u", lb->protocol,
+                      port);
+    }
+    action = xasprintf("trigger_event(event = \"%s\", "
+                   "vip = \"%s\", protocol = \"%s\", "
+                   "load_balancer = \"" UUID_FMT "\");",
+                   event_to_string(OVN_EVENT_EMPTY_LB_BACKENDS),
+                   node->key, lb->protocol,
+                   UUID_ARGS(&lb->header_.uuid));
+    ovn_lflow_add(lflows, od, pl, 130, ds_cstr(&match), action);
+    ds_destroy(&match);
+    free(action);
+}
+
 static void
 build_pre_lb(struct ovn_datapath *od, struct hmap *lflows)
 {
@@ -4038,32 +4073,8 @@  build_pre_lb(struct ovn_datapath *od, struct hmap *lflows)
                 sset_add(&all_ips, ip_address);
             }
 
-            if (controller_event_en && !node->value[0]) {
-                struct ds match = DS_EMPTY_INITIALIZER;
-                char *action;
-
-                if (addr_family == AF_INET) {
-                    ds_put_format(&match, "ip4.dst == %s && %s",
-                                  ip_address, lb->protocol);
-                } else {
-                    ds_put_format(&match, "ip6.dst == %s && %s",
-                                  ip_address, lb->protocol);
-                }
-                if (port) {
-                    ds_put_format(&match, " && %s.dst == %u", lb->protocol,
-                                  port);
-                }
-                action = xasprintf("trigger_event(event = \"%s\", "
-                               "vip = \"%s\", protocol = \"%s\", "
-                               "load_balancer = \"" UUID_FMT "\");",
-                               event_to_string(OVN_EVENT_EMPTY_LB_BACKENDS),
-                               node->key, lb->protocol,
-                               UUID_ARGS(&lb->header_.uuid));
-                ovn_lflow_add(lflows, od, S_SWITCH_IN_PRE_LB, 120,
-                              ds_cstr(&match), action);
-                ds_destroy(&match);
-                free(action);
-            }
+            build_empty_lb_event_flow(od, lflows, node, ip_address, lb,
+                                      port, addr_family, S_SWITCH_IN_PRE_LB);
 
             free(ip_address);