[ovs-dev,v2.12] OVN: fix memory leak in build_pre_lb
diff mbox series

Message ID cd16fd909cb960823b2ddacfcb37d9812da08f8b.1566811041.git.lorenzo.bianconi@redhat.com
State Accepted
Headers show
Series
  • [ovs-dev,v2.12] OVN: fix memory leak in build_pre_lb
Related show

Commit Message

Lorenzo Bianconi Aug. 26, 2019, 9:19 a.m. UTC
Fix memory leak of ip_address string in build_pre_lb routine if we
install logical flows for empty_lb controller event

Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report 'empty_lb_rule' events")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 ovn/northd/ovn-northd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ben Pfaff Aug. 28, 2019, 7:14 p.m. UTC | #1
On Mon, Aug 26, 2019 at 11:19:32AM +0200, Lorenzo Bianconi wrote:
> Fix memory leak of ip_address string in build_pre_lb routine if we
> install logical flows for empty_lb controller event
> 
> Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report 'empty_lb_rule' events")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Thanks, applied.

Patch
diff mbox series

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 2abf1f897..6c6de2afd 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -3943,7 +3943,6 @@  build_pre_lb(struct ovn_datapath *od, struct hmap *lflows)
                               ds_cstr(&match), action);
                 ds_destroy(&match);
                 free(action);
-                continue;
             }
 
             free(ip_address);