[ovs-dev,ovn] Fix memory leak in build_pre_lb
diff mbox series

Message ID 6b192682f88c91d550dd3181254987a33a6c036b.1566755169.git.lorenzo.bianconi@redhat.com
State Accepted
Headers show
Series
  • [ovs-dev,ovn] Fix memory leak in build_pre_lb
Related show

Commit Message

Lorenzo Bianconi Aug. 25, 2019, 6:02 p.m. UTC
Fix memory leak of ip_address string in build_pre_lb routine if we
install logical flows for empty_lb controller event

Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report 'empty_lb_rule' events")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 northd/ovn-northd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Numan Siddique Aug. 26, 2019, 11:22 a.m. UTC | #1
On Sun, Aug 25, 2019 at 11:32 PM Lorenzo Bianconi <
lorenzo.bianconi@redhat.com> wrote:

> Fix memory leak of ip_address string in build_pre_lb routine if we
> install logical flows for empty_lb controller event
>
> Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report
> 'empty_lb_rule' events")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>

Thanks Lorenzo.
I applied this patch to ovn master.

Numan


> ---
>  northd/ovn-northd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index e29b0fff4..ca128c996 100644
> --- a/northd/ovn-northd.c
> +++ b/northd/ovn-northd.c
> @@ -4063,7 +4063,6 @@ build_pre_lb(struct ovn_datapath *od, struct hmap
> *lflows)
>                                ds_cstr(&match), action);
>                  ds_destroy(&match);
>                  free(action);
> -                continue;
>              }
>
>              free(ip_address);
> --
> 2.21.0
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

Patch
diff mbox series

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index e29b0fff4..ca128c996 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -4063,7 +4063,6 @@  build_pre_lb(struct ovn_datapath *od, struct hmap *lflows)
                               ds_cstr(&match), action);
                 ds_destroy(&match);
                 free(action);
-                continue;
             }
 
             free(ip_address);