From patchwork Fri Aug 23 18:28:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1152330 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jZIxo1VN"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46FVKX2GY3z9s00 for ; Sat, 24 Aug 2019 04:29:03 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B27BAF48; Fri, 23 Aug 2019 18:29:00 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 992F2F42 for ; Fri, 23 Aug 2019 18:28:59 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5DE4267F for ; Fri, 23 Aug 2019 18:28:59 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id g2so6992232pfq.0 for ; Fri, 23 Aug 2019 11:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zTKgNFXluOdElo89651LY+70jVgXFTJD7PiN9tJdUxg=; b=jZIxo1VNMr2vwjM1r8235e+YZJRxbMV6rsxTjail9IPrz+rW5T0oulZFwBpyFhNp0u kc6mAAGQqQ/rC5pDT1WGgbkNBWvu8uFtda1Wkew4yPCYYlq7GzHHdrS+4j7ZQgi8GvEx XJ67/k7XBIXRpCSUxjebv71Tj0qZhq0+VJKbSyEJhEs6tpgxc2HVxR07GEhxWygAGONB FJaGl3zGbc1otvQ47QCru8LODSYzXQRjQIKzgyINGA1mUFp6vcqfmQvjB52mbP9pPZDU t4Lukg5QML9wp5F8fQOqDl69q1oTMm0D8im/DU257FMv/eG3qBsWfRZR6//2tDHaAG4f Ihsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zTKgNFXluOdElo89651LY+70jVgXFTJD7PiN9tJdUxg=; b=iL8xMjh8CsNlsniTB0Lm7eamuBAfc2wNZSWZWUwm8EMTtBv9llqqmyWWzzn7G9EpRn 7nc7uKTmYk10HBHYYTCMsB3aW8XU5+yerPNfLN8ZI8UVB46fGMSAFSVjjJM8p3UEBhIC nQN38ambcawT24dQ9ZXg6q1cDVFi9XMLXPKBoCeIRp1A5XCxGGeGqVSF5UKjBUc1mtDp aWoX88AfB1bu0k6G5tCPt2/buWfmWanJrPhzb0hv2eiGrWvhttRXywzbbTps0LnZlcsn C675dq/MxmVzRa1VVV16TLC5EMxJb/JfoCA8DqaNLSSON5+MGiqFWVu9GzX/m/MI+WKs 4xiw== X-Gm-Message-State: APjAAAVik42/JzpfEHHEnzOe+vRxngzDsqUZWIih4VALKYv1kGQyjlti XdJpHsy/67YR6N2o5GBRNg9838Y8qR8= X-Google-Smtp-Source: APXvYqwQh0ywKawbRLaEfQHH5tD3VMg78zR37JIYTr+hBnYiMBTVlOoDrkRploMzDJeBz8KOBKZjrQ== X-Received: by 2002:a63:394:: with SMTP id 142mr5185747pgd.43.1566584938419; Fri, 23 Aug 2019 11:28:58 -0700 (PDT) Received: from sc9-mailhost2.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id i137sm4295130pgc.4.2019.08.23.11.28.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Aug 2019 11:28:57 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Fri, 23 Aug 2019 11:28:12 -0700 Message-Id: <1566584892-2234-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Gurucharan Shetty Subject: [ovs-dev] [PATCH] ovs-lib: Add timeout at ovs-check-dead-ifs. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read an entry in /proc//fd/ but hangs forever. The pid is a qemu-system-x86_64 process and we suspect it's an issue related to qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge never gets restarted. This patch adds a timeout of 5-seconds to ovs-check-dead-ifs. VMware-BZ: #2408059 Signed-off-by: William Tu Cc: Ashish Varma Cc: Gurucharan Shetty --- utilities/ovs-lib.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index fa840ec637f5..4cdc2a6d5d22 100644 --- a/utilities/ovs-lib.in +++ b/utilities/ovs-lib.in @@ -653,7 +653,7 @@ force_reload_kmod () { restore_interfaces - "$datadir/scripts/ovs-check-dead-ifs" + timeout 5 "$datadir/scripts/ovs-check-dead-ifs" } ## ------- ##