From patchwork Thu Aug 22 16:51:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 1151703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46DrCt2nwPz9sBp for ; Fri, 23 Aug 2019 02:51:54 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A089DB2F; Thu, 22 Aug 2019 16:51:51 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E0B208BF for ; Thu, 22 Aug 2019 16:51:49 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9118267F for ; Thu, 22 Aug 2019 16:51:49 +0000 (UTC) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DAA5FC08E285 for ; Thu, 22 Aug 2019 16:51:48 +0000 (UTC) Received: by mail-wr1-f72.google.com with SMTP id k10so3451463wru.23 for ; Thu, 22 Aug 2019 09:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=0KJuH1VrQOZ8zqcQhLgAtOEn1Z0xnQI+jI+B7WgAVJ4=; b=GLs4vIT8D+O6lXJ8wHKIjKfClN7OWGWa/TB0TAkOTdnMPCihYgLrAJgh8rKuhuBIRv m3JFalGrWzaIggVFfy+p+S8W/HlCWfZKx/JIFFJ02hQQjUclUsK78zIzfWXlzhj6pRf2 7+2ugcWpwiCTmCgm8mvQd5OHKJP4nrgJw6OooqtPv39h1uGNfUmEPM/kkJ03XKs4SoiW YhcrGnpZ0b5y/QYJxptT8JYndtlkZuZGhw1hlV0S6ndv/3ECmfoe8+qTaP+7hanzCRH/ 6jdbZWaQ4VLKpiqH4AI1ByXW1p53dTjQHvfOGKyBUwYtO9JyJVfZwtOAhMn44/iRxeR7 kk0A== X-Gm-Message-State: APjAAAUftxaHywfw+2enP2hNlsUBaSMYVM5QO8CNd89CU0zmRY3YvErk rVGH5S34ej4dIfJ4575k/lc7AtZmxZlpsqt0rzoaM7KuMw8eBZH5QFEG4BjDK/TDKfoM6VqfhCq 4TgSIa7jHo2XS/UyZjQ== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr7616347wmk.79.1566492707423; Thu, 22 Aug 2019 09:51:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWH/5HzjKjyJkFAP8rXpQEGU0yShCakvANZM34pdDvLQf/EeUSxWK3ep7cQHmTUERD/cIOBQ== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr7616322wmk.79.1566492707135; Thu, 22 Aug 2019 09:51:47 -0700 (PDT) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id g7sm129532wme.17.2019.08.22.09.51.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 09:51:46 -0700 (PDT) From: Lorenzo Bianconi To: ovs-dev@openvswitch.org Date: Thu, 22 Aug 2019 18:51:40 +0200 Message-Id: <1679a0e2264b4ed8c116c6f2658fa38e7ea71723.1566492618.git.lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH ovn] Remove ageing check in run_put_mac_binding X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Remove ageing check in run_put_mac_binding routine on mac-binding info since if ovn-controller main thread is heavy loaded the info will be discarded and the mac_binding table will not never be updated Signed-off-by: Lorenzo Bianconi Acked-by: Numan Siddique --- controller/pinctrl.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index 365a0d16d..21ed75fee 100644 --- a/controller/pinctrl.c +++ b/controller/pinctrl.c @@ -2549,8 +2549,6 @@ pinctrl_destroy(void) struct put_mac_binding { struct hmap_node hmap_node; /* In 'put_mac_bindings'. */ - long long int timestamp; /* In milliseconds. */ - /* Key. */ uint32_t dp_key; uint32_t port_key; @@ -2624,7 +2622,6 @@ pinctrl_handle_put_mac_binding(const struct flow *md, pmb->port_key = port_key; pmb->ip_key = ip_key; } - pmb->timestamp = time_msec(); pmb->mac = headers->dl_src; /* We can send the buffered packet once the main ovn-controller @@ -2672,10 +2669,6 @@ run_put_mac_binding(struct ovsdb_idl_txn *ovnsb_idl_txn, struct ovsdb_idl_index *sbrec_mac_binding_by_lport_ip, const struct put_mac_binding *pmb) { - if (time_msec() > pmb->timestamp + 1000) { - return; - } - /* Convert logical datapath and logical port key into lport. */ const struct sbrec_port_binding *pb = lport_lookup_by_key( sbrec_datapath_binding_by_key, sbrec_port_binding_by_key,