From patchwork Mon Aug 19 14:37:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 1149319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46BxNh5JcHz9s3Z for ; Tue, 20 Aug 2019 00:37:56 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 98A30E6D; Mon, 19 Aug 2019 14:37:18 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CE292E5A for ; Mon, 19 Aug 2019 14:37:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 80A6489E for ; Mon, 19 Aug 2019 14:37:17 +0000 (UTC) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ECCC27BDB0 for ; Mon, 19 Aug 2019 14:37:16 +0000 (UTC) Received: by mail-wm1-f70.google.com with SMTP id b11so308824wmj.0 for ; Mon, 19 Aug 2019 07:37:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F/4EyAQyZWJI80wZHaukfAQR3AWmg8atYdAW0AUJ53U=; b=UgA7qSsCU2F8YhR+enoa+x11xK1Y07BFgvKx3fU/hcv1nnqB3/TbLDGE6hg3IJ3stl BCW7PQCR8l0L3EIF6gnXwtqwi+byMKbfaUhscRpXwHx6lIm9iZC/2ddByGY/9fd3l99+ t8UmPa1BQIvhpopFTPheetoarRd/TcIUFkOXOISwnJesxvx7+4v/D33Odw/4qlMys5Pl 5fw4AlTi4s1F1MRL4o3ochNMfpvsxpNyKICBI73yxGXS1hbFFlfdEjtLW3DLMlg+uNN0 1O2pjVHGZRtP+wGdGPBWcScsVDIDvmS3/hr73P4uDtqvYiP/BgZ2/iFa5KZMrt2uhaZJ 834Q== X-Gm-Message-State: APjAAAUrTlvS/Iv37YYEY2ymKVM155fjWD80KRKs4DIhwLbGDHvEKlfQ nbYR//jdxwsZbJm4BHIP8YzPHDqpc2dHEMt8d07wN6fw0JyZFm1GQQeRHNWo1KHxz6rvxYHrPuO 4VbfsYSlTO1f4tKhzBA== X-Received: by 2002:a05:600c:24cf:: with SMTP id 15mr20770503wmu.76.1566225435384; Mon, 19 Aug 2019 07:37:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzctCAWEaQhCqDzsMzcISMg1TPjsnLVePUTqooLg7KtZzmBVPe5ITr0KPGZk5xab3S0M7wWHw== X-Received: by 2002:a05:600c:24cf:: with SMTP id 15mr20770482wmu.76.1566225435145; Mon, 19 Aug 2019 07:37:15 -0700 (PDT) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id d16sm22136702wrj.47.2019.08.19.07.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 07:37:14 -0700 (PDT) From: Lorenzo Bianconi To: ovs-dev@openvswitch.org Date: Mon, 19 Aug 2019 16:37:01 +0200 Message-Id: <7093fcd02b89ecb8256c4fd1a113f4e79753d180.1566222622.git.lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Mark Michelson From: Mark Michelson Controller event action is leaking its genopts. This corrects the error. Signed-off-by: Mark Michelson Signed-off-by: Lorenzo Bianconi --- lib/actions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/actions.c b/lib/actions.c index 81950e7df..08c589ab3 100644 --- a/lib/actions.c +++ b/lib/actions.c @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, } static void -ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED) +ovnact_controller_event_free(struct ovnact_controller_event *event) { + free_gen_options(event->options, event->n_options); } static void