Message ID | 7093fcd02b89ecb8256c4fd1a113f4e79753d180.1566222622.git.lorenzo.bianconi@redhat.com |
---|---|
State | Accepted |
Headers | show |
Series | add rate limiting support for controller_events | expand |
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> Lines checked: 33, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Mon, Aug 19, 2019 at 8:08 PM Lorenzo Bianconi < lorenzo.bianconi@redhat.com> wrote: > From: Mark Michelson <mmichels@redhat.com> > > From: Mark Michelson <mmichels@redhat.com> > > Controller event action is leaking its genopts. This corrects the error. > > Signed-off-by: Mark Michelson <mmichels@redhat.com> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > I applied this patch of this series to master. I edited the commit message as there was "From" tag at the start of the commit body. Thanks Numan > --- > lib/actions.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/actions.c b/lib/actions.c > index 81950e7df..08c589ab3 100644 > --- a/lib/actions.c > +++ b/lib/actions.c > @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, > } > > static void > -ovnact_controller_event_free(struct ovnact_controller_event *event > OVS_UNUSED) > +ovnact_controller_event_free(struct ovnact_controller_event *event) > { > + free_gen_options(event->options, event->n_options); > } > > static void > -- > 2.21.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/lib/actions.c b/lib/actions.c index 81950e7df..08c589ab3 100644 --- a/lib/actions.c +++ b/lib/actions.c @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, } static void -ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED) +ovnact_controller_event_free(struct ovnact_controller_event *event) { + free_gen_options(event->options, event->n_options); } static void