[ovs-dev,v2.12] OVN: Repair memory leak for OVN controller events.
diff mbox series

Message ID 20190815181218.22206-1-mmichels@redhat.com
State New
Headers show
Series
  • [ovs-dev,v2.12] OVN: Repair memory leak for OVN controller events.
Related show

Commit Message

Mark Michelson Aug. 15, 2019, 6:12 p.m. UTC
Controller event action is leaking its genopts. This corrects the error.
---
 ovn/lib/actions.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

0-day Robot Aug. 19, 2019, 1:37 p.m. UTC | #1
Bleep bloop.  Greetings Mark Michelson, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Mark Michelson <mmichels@redhat.com> needs to sign off.
Lines checked: 29, Warnings: 0, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Ben Pfaff Aug. 28, 2019, 10:59 p.m. UTC | #2
On Thu, Aug 15, 2019 at 02:12:18PM -0400, Mark Michelson wrote:
> Controller event action is leaking its genopts. This corrects the error.

Needs a Signed-off-by.
Mark Michelson Aug. 29, 2019, 6:04 p.m. UTC | #3
On 8/28/19 6:59 PM, Ben Pfaff wrote:
> On Thu, Aug 15, 2019 at 02:12:18PM -0400, Mark Michelson wrote:
>> Controller event action is leaking its genopts. This corrects the error.
> 
> Needs a Signed-off-by.
> 

I've sent a v2 that corrects this.

Patch
diff mbox series

diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c
index b0cb3490b..274297194 100644
--- a/ovn/lib/actions.c
+++ b/ovn/lib/actions.c
@@ -1760,8 +1760,9 @@  parse_trigger_event(struct action_context *ctx,
 }
 
 static void
-ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED)
+ovnact_controller_event_free(struct ovnact_controller_event *event)
 {
+    free_gen_options(event->options, event->n_options);
 }
 
 static void