Message ID | 20190815181218.22206-1-mmichels@redhat.com |
---|---|
State | Superseded |
Headers | show |
Series | [ovs-dev,v2.12] OVN: Repair memory leak for OVN controller events. | expand |
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mark Michelson <mmichels@redhat.com> needs to sign off. Lines checked: 29, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Thu, Aug 15, 2019 at 02:12:18PM -0400, Mark Michelson wrote:
> Controller event action is leaking its genopts. This corrects the error.
Needs a Signed-off-by.
On 8/28/19 6:59 PM, Ben Pfaff wrote: > On Thu, Aug 15, 2019 at 02:12:18PM -0400, Mark Michelson wrote: >> Controller event action is leaking its genopts. This corrects the error. > > Needs a Signed-off-by. > I've sent a v2 that corrects this.
diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index b0cb3490b..274297194 100644 --- a/ovn/lib/actions.c +++ b/ovn/lib/actions.c @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, } static void -ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED) +ovnact_controller_event_free(struct ovnact_controller_event *event) { + free_gen_options(event->options, event->n_options); } static void