From patchwork Tue Aug 13 16:37:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1146497 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="YlRw68MH"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 467JLC2scjz9sDQ for ; Wed, 14 Aug 2019 02:38:11 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D0AD0B1F; Tue, 13 Aug 2019 16:38:08 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AA3C6AD0 for ; Tue, 13 Aug 2019 16:38:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 175B88D for ; Tue, 13 Aug 2019 16:38:06 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190813163804euoutp02777f6176e25f3f55188958a3597025dc~6iNicAlyW2989729897euoutp02w for ; Tue, 13 Aug 2019 16:38:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190813163804euoutp02777f6176e25f3f55188958a3597025dc~6iNicAlyW2989729897euoutp02w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1565714284; bh=Yk11TraQ5K/5MyIiA7BbveGYKtxrmR0P+4bzyhIygOo=; h=From:To:Cc:Subject:Date:References:From; b=YlRw68MH5MuZRvnu9dqyq2udadOKoDeGT+udQUnVDyZ+EyhKcX5Lou0C6QAvPih3Y K0YtQ2Lz3Vq55GCjx57Te7FcXyITbOqmbZIRGjSgsjgNo0lzay+MrXLB79vYZN1uf8 /PsYGMJTxtqMa+hyTbC6APVjWxweMTRQMGU1eOsA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190813163803eucas1p22c555d1c92586c4c48e3543298c62bdb~6iNhQlxcg1620916209eucas1p28; Tue, 13 Aug 2019 16:38:03 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id B4.24.04309.A67E25D5; Tue, 13 Aug 2019 17:38:02 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190813163802eucas1p1423f43e47c5735daaa9b976ade73ad38~6iNgT7OOo2831328313eucas1p1r; Tue, 13 Aug 2019 16:38:02 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190813163801eusmtrp2bee1318ddd633209d344f3ac5b59a90e~6iNgBjtwR0849308493eusmtrp2R; Tue, 13 Aug 2019 16:38:01 +0000 (GMT) X-AuditID: cbfec7f4-afbff700000010d5-7c-5d52e76ae64e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 73.88.04117.967E25D5; Tue, 13 Aug 2019 17:38:01 +0100 (BST) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190813163801eusmtip2863bfb3cd74f6ba234a74f02b2ad9219~6iNfiJDr42313323133eusmtip26; Tue, 13 Aug 2019 16:38:01 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Tue, 13 Aug 2019 19:37:57 +0300 Message-Id: <20190813163757.473-1-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsWy7djP87pZz4NiDT5s0LXYvqKLzeLOlZ9s Flfaf7JbbHx4ltVi7aEP7BZzPz1ndGDzWLznJZPHs5v/GT3e77vK5tG3ZRVjAEsUl01Kak5m WWqRvl0CV8bLJy+ZCmbzVqxZv4GxgfETZxcjJ4eEgInEn3UzmboYuTiEBFYwSix4d48RwvnC KPHv8S2ozGdGiTVTmtlgWj7OmQdVtZxR4sylFVBVPxgllmx9ClbFJqAjcWr1EUYQW0RAWuJ1 7xtWkCJmgROMEr/f9oMlhAUcJe683gdmswioSlx6OYsZxOYVsJTYu7GVFWKdvMTqDQeYQZol BE6wSXw7vYERIuEiMaHzF5QtLPHq+BZ2CFtG4v/O+UwQdr3E/ZaXjBDNHYwS0w/9g0rYS2x5 fQ6ogQPoJE2J9bv0IcKOEsta1jCDhCUE+CRuvBUECTMDmZO2TYcK80p0tAlBVKtI/D64nBnC lpK4+e4z1AUeEu+3zwZbJCQQK/H/xxXWCYxysxB2LWBkXMUonlpanJueWmyUl1quV5yYW1ya l66XnJ+7iREY/af/Hf+yg3HXn6RDjAIcjEo8vAFbgmKFWBPLiitzDzFKcDArifBOuAgU4k1J rKxKLcqPLyrNSS0+xCjNwaIkzlvN8CBaSCA9sSQ1OzW1ILUIJsvEwSnVwOi99YlUaL/o/7wA z1MXwmzeLr17cQHnl/DTOxcG5m/6mG+0WkBFWS7/ila86t2IJ+9yj+wt+B5qM1k16ZqCTi2b 9zL/dak1Dw9P8zaJvnG+tW7n+cLOpuNHF/Ql+N/T3/Hsx76F/5pkDBQ8bMq++koIftjlIjrX tUPgK+Or6fLFSddk2C165yqxFGckGmoxFxUnAgD23krw+gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLLMWRmVeSWpSXmKPExsVy+t/xe7qZz4NiDRpua1tsX9HFZnHnyk82 iyvtP9ktNj48y2qx9tAHdou5n54zOrB5LN7zksnj2c3/jB7v911l8+jbsooxgCVKz6Yov7Qk VSEjv7jEVina0MJIz9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI3y5BL+Plk5dMBbN5K9as 38DYwPiJs4uRk0NCwETi45x5jF2MXBxCAksZJZ61drBDJKQkfvy6wAphC0v8udbFBlH0jVGi 5909JpAEm4COxKnVRxhBbBEBaYnXvW9YQYqYBc4wSlzbcA0sISzgKHHn9T4wm0VAVeLSy1nM IDavgKXE3o2tUBvkJVZvOMA8gZFnASPDKkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMCg23bs 55YdjF3vgg8xCnAwKvHwBmwJihViTSwrrsw9xCjBwawkwjvhIlCINyWxsiq1KD++qDQntfgQ oynQ8onMUqLJ+cCIyCuJNzQ1NLewNDQ3Njc2s1AS5+0QOBgjJJCeWJKanZpakFoE08fEwSnV wHgw6P1my65E1v28DXNq/ymKb3K6c/T/WdvDYZpKp/ONPBYdWTNZv6iyKe141MrNK4S5bY86 qaqH77vbG7BY/YtYyPf9RbmXD3sd7tFb9cxjHvOJR92Xk2benuyX/Hf9u0X/y4RL/EsWHFwk FGmlv4vVXO7nm8sOascYjF8sOqziuTqiM/Uko4QSS3FGoqEWc1FxIgCQ4xhyUAIAAA== X-CMS-MailID: 20190813163802eucas1p1423f43e47c5735daaa9b976ade73ad38 X-Msg-Generator: CA X-RootMTR: 20190813163802eucas1p1423f43e47c5735daaa9b976ade73ad38 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190813163802eucas1p1423f43e47c5735daaa9b976ade73ad38 References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , David Marchand Subject: [ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This is highly useful to see on which core PMD is running by only looking at the thread name. Thread Id still allows to distinguish different threads running on the same core over the time: |dpif_netdev(pmd-c10/id:53)|DBG|Creating 2. subtable <...> |dpif_netdev(pmd-c10/id:53)|DBG|flow_add: <...>, actions:2 |dpif_netdev(pmd-c09/id:70)|DBG|Core 9 processing port <..> In gdb, top or any other utility it's useful to quickly catch up needed thread without parsing logs, memory or matching threads by port names they're handling. Signed-off-by: Ilya Maximets Acked-by: Eelco Chaudron Reviewed-by: David Marchand --- lib/dpif-netdev.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index d0a1c58ad..34ba03836 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4735,9 +4735,16 @@ reconfigure_pmd_threads(struct dp_netdev *dp) FOR_EACH_CORE_ON_DUMP(core, pmd_cores) { pmd = dp_netdev_get_pmd(dp, core->core_id); if (!pmd) { + struct ds name = DS_EMPTY_INITIALIZER; + pmd = xzalloc(sizeof *pmd); dp_netdev_configure_pmd(pmd, dp, core->core_id, core->numa_id); - pmd->thread = ovs_thread_create("pmd", pmd_thread_main, pmd); + + ds_put_format(&name, "pmd-c%02d/id:", core->core_id); + pmd->thread = ovs_thread_create(ds_cstr(&name), + pmd_thread_main, pmd); + ds_destroy(&name); + VLOG_INFO("PMD thread on numa_id: %d, core id: %2d created.", pmd->numa_id, pmd->core_id); changed = true;