[ovs-dev,v2,ovn] logical-fields: fix memory leak while initializing ovnfield_by_name
diff mbox series

Message ID 1565177365-27156-1-git-send-email-damjan.skvarc@gmail.com
State New
Headers show
Series
  • [ovs-dev,v2,ovn] logical-fields: fix memory leak while initializing ovnfield_by_name
Related show

Commit Message

Damijan Skvarc Aug. 7, 2019, 11:29 a.m. UTC
fixed 0-day Robot issues 

Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com>
---
 lib/logical-fields.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

0-day Robot Aug. 7, 2019, 12:02 p.m. UTC | #1
Bleep bloop.  Greetings Damijan Skvarc, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


git-am:
Failed to merge in the changes.
Patch failed at 0001 logical-fields: fix memory leak while initializing ovnfield_by_name
The copy of the patch that failed is found in:
   /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/OVN/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot

Patch
diff mbox series

diff --git a/lib/logical-fields.c b/lib/logical-fields.c
index 62b9a71..fdc78cf 100644
--- a/lib/logical-fields.c
+++ b/lib/logical-fields.c
@@ -57,9 +57,8 @@  add_ct_bit(const char *name, int index, struct shash *symtab)
     free(expansion);
 }
 
-
 static void
-init_ovnfield_by_name()
+init_ovnfield_by_name(void)
 {
     static bool initialized = 0;
 
@@ -70,7 +69,7 @@  init_ovnfield_by_name()
             ovs_assert(of->id == i); /* Fields must be in the enum order. */
             shash_add_once(&ovnfield_by_name, of->name, of);
         }
-        initialized=1;
+        initialized = 1;
     }
 }