| Message ID | 20190806102302.9338-1-peng.fan@nxp.com |
|---|---|
| State | Accepted |
| Commit | 4d655bfe03a35a2f85b2b779342b135c54d055a0 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot] tools: imx8mimage: fix HDMI/FIT parsing | expand |
> Add missed break for HDMI entry. > And moving FIT parsing earlier, because it does not have parameter, > it will not runs into CFG_REG_SIZE. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > tools/imx8mimage.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c > index 50a256cbac..6c02337698 100644 > --- a/tools/imx8mimage.c > +++ b/tools/imx8mimage.c > @@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno) > break; > case CMD_SIGNED_HDMI: > signed_hdmi = token; > - case CMD_FIT: > - using_fit = 1; > break; > case CMD_DDR_FW: > /* Do nothing */ > @@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char *token, > name, lineno, token); > exit(EXIT_FAILURE); > } > + switch (*cmd) { > + case CMD_FIT: > + using_fit = 1; > + break; > + } > break; > case CFG_REG_SIZE: > parse_cfg_cmd(*cmd, token, name, lineno); > Reviewed-by: Ye Li <ye.li@nxp.com> Best regards, Ye Li
On Tue, 6 Aug 2019 10:07:26 +0000 Peng Fan <peng.fan@nxp.com> wrote: > Add missed break for HDMI entry. > And moving FIT parsing earlier, because it does not have parameter, > it will not runs into CFG_REG_SIZE. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > tools/imx8mimage.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c > index 50a256cbac..6c02337698 100644 > --- a/tools/imx8mimage.c > +++ b/tools/imx8mimage.c > @@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, > char *name, int lineno) break; > case CMD_SIGNED_HDMI: > signed_hdmi = token; > - case CMD_FIT: > - using_fit = 1; > break; > case CMD_DDR_FW: > /* Do nothing */ > @@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char > *token, name, lineno, token); > exit(EXIT_FAILURE); > } > + switch (*cmd) { > + case CMD_FIT: > + using_fit = 1; > + break; > + } > break; > case CFG_REG_SIZE: > parse_cfg_cmd(*cmd, token, name, lineno); Reviewed-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
> Subject: [PATCH] tools: imx8mimage: fix HDMI/FIT parsing > > Add missed break for HDMI entry. > And moving FIT parsing earlier, because it does not have parameter, it will not > runs into CFG_REG_SIZE. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- Applied to nxp-imx-8-13, https://github.com/MrVan/u-boot/tree/nxp-imx-8-13 Regards, Peng.
diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c index 50a256cbac..6c02337698 100644 --- a/tools/imx8mimage.c +++ b/tools/imx8mimage.c @@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno) break; case CMD_SIGNED_HDMI: signed_hdmi = token; - case CMD_FIT: - using_fit = 1; break; case CMD_DDR_FW: /* Do nothing */ @@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char *token, name, lineno, token); exit(EXIT_FAILURE); } + switch (*cmd) { + case CMD_FIT: + using_fit = 1; + break; + } break; case CFG_REG_SIZE: parse_cfg_cmd(*cmd, token, name, lineno);
Add missed break for HDMI entry. And moving FIT parsing earlier, because it does not have parameter, it will not runs into CFG_REG_SIZE. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- tools/imx8mimage.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)