diff mbox series

package/imagemagick: fix host build for old distributions

Message ID 20190802134044.22094-1-peter@korsgaard.com
State Accepted
Commit 273427f9286d0d0fd4c02cfd681f3a19bc045064
Headers show
Series package/imagemagick: fix host build for old distributions | expand

Commit Message

Peter Korsgaard Aug. 2, 2019, 1:40 p.m. UTC
Fixes:
http://autobuild.buildroot.net/results/5f0/5f0b85033e800c9eebc46812592966ec6826bb5d/

imagemagick uses clock_gettime, which was provided by librt rather than libc
in glibc < 2.17 - Causing link errors.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/imagemagick/imagemagick.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Yann E. MORIN Aug. 2, 2019, 2:41 p.m. UTC | #1
Peter, All,

On 2019-08-02 15:40 +0200, Peter Korsgaard spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/5f0/5f0b85033e800c9eebc46812592966ec6826bb5d/
> 
> imagemagick uses clock_gettime, which was provided by librt rather than libc
> in glibc < 2.17 - Causing link errors.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/imagemagick/imagemagick.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
> index fff00fcfb1..3a37371e7b 100644
> --- a/package/imagemagick/imagemagick.mk
> +++ b/package/imagemagick/imagemagick.mk
> @@ -176,6 +176,9 @@ HOST_IMAGEMAGICK_CONF_OPTS = \
>  	--with-png \
>  	--with-zlib
>  
> +# uses clock_gettime, which was provided by librt in glibc < 2.17
> +HOST_IMAGEMAGICK_CONF_ENV = LIBS="-lrt"
> +
>  HOST_IMAGEMAGICK_DEPENDENCIES = \
>  	host-libjpeg \
>  	host-libpng \
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Yann E. MORIN Aug. 2, 2019, 2:48 p.m. UTC | #2
Peter, All,

On 2019-08-02 15:40 +0200, Peter Korsgaard spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/5f0/5f0b85033e800c9eebc46812592966ec6826bb5d/
> 
> imagemagick uses clock_gettime, which was provided by librt rather than libc
> in glibc < 2.17 - Causing link errors.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/imagemagick/imagemagick.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
> index fff00fcfb1..3a37371e7b 100644
> --- a/package/imagemagick/imagemagick.mk
> +++ b/package/imagemagick/imagemagick.mk
> @@ -176,6 +176,9 @@ HOST_IMAGEMAGICK_CONF_OPTS = \
>  	--with-png \
>  	--with-zlib
>  
> +# uses clock_gettime, which was provided by librt in glibc < 2.17
> +HOST_IMAGEMAGICK_CONF_ENV = LIBS="-lrt"
> +
>  HOST_IMAGEMAGICK_DEPENDENCIES = \
>  	host-libjpeg \
>  	host-libpng \
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Aug. 2, 2019, 5:47 p.m. UTC | #3
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/5f0/5f0b85033e800c9eebc46812592966ec6826bb5d/

 > imagemagick uses clock_gettime, which was provided by librt rather than libc
 > in glibc < 2.17 - Causing link errors.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed, thanks.
Peter Korsgaard Aug. 29, 2019, 9:08 p.m. UTC | #4
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/5f0/5f0b85033e800c9eebc46812592966ec6826bb5d/

 > imagemagick uses clock_gettime, which was provided by librt rather than libc
 > in glibc < 2.17 - Causing link errors.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2019.02.x and 2019.05.x, thanks.
diff mbox series

Patch

diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
index fff00fcfb1..3a37371e7b 100644
--- a/package/imagemagick/imagemagick.mk
+++ b/package/imagemagick/imagemagick.mk
@@ -176,6 +176,9 @@  HOST_IMAGEMAGICK_CONF_OPTS = \
 	--with-png \
 	--with-zlib
 
+# uses clock_gettime, which was provided by librt in glibc < 2.17
+HOST_IMAGEMAGICK_CONF_ENV = LIBS="-lrt"
+
 HOST_IMAGEMAGICK_DEPENDENCIES = \
 	host-libjpeg \
 	host-libpng \