| Message ID | 20190801064931.21943-1-stewart@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | doc/device-tree/ibm, opal/firmware/version: clarify timeline of git-id vs version | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (2554cac82da530acfcb1a575c571e760de92dde4) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On 08/01/2019 12:19 PM, Stewart Smith wrote: > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > --- > doc/device-tree/ibm,opal/firmware.rst | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/doc/device-tree/ibm,opal/firmware.rst b/doc/device-tree/ibm,opal/firmware.rst > index ae84100780b3..5e76199ec909 100644 > --- a/doc/device-tree/ibm,opal/firmware.rst > +++ b/doc/device-tree/ibm,opal/firmware.rst > @@ -22,8 +22,12 @@ The 'firmware' node under 'ibm,opal' lists system and OPAL firmware version. > property describes OPAL symbol start address and size. > > ``version`` > - property describes OPAL version. Replaces 'git-id', so may > - not be present. On POWER9 and above, it is always present. > + property describes OPAL version. It replaced a property named 'git-id' early > + in the POWER8 lifecycle, so may not always be present. It will be absent on > + IBM FSP based systems running firmware prior to FW840. The 'version' property > + is present on all GA POWER8 BMC systems. > + > + On POWER9 and above, it is always present. Looks good. Thanks for the update. Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> -Vasant
diff --git a/doc/device-tree/ibm,opal/firmware.rst b/doc/device-tree/ibm,opal/firmware.rst index ae84100780b3..5e76199ec909 100644 --- a/doc/device-tree/ibm,opal/firmware.rst +++ b/doc/device-tree/ibm,opal/firmware.rst @@ -22,8 +22,12 @@ The 'firmware' node under 'ibm,opal' lists system and OPAL firmware version. property describes OPAL symbol start address and size. ``version`` - property describes OPAL version. Replaces 'git-id', so may - not be present. On POWER9 and above, it is always present. + property describes OPAL version. It replaced a property named 'git-id' early + in the POWER8 lifecycle, so may not always be present. It will be absent on + IBM FSP based systems running firmware prior to FW840. The 'version' property + is present on all GA POWER8 BMC systems. + + On POWER9 and above, it is always present. ``mi-version`` property describes Microcode Image. Only on IBM FSP systems.
Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- doc/device-tree/ibm,opal/firmware.rst | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)