diff mbox series

[U-Boot,2/2] net: mdio: Clarify code flow Covarity 244085 & 244090

Message ID 20190730215757.47085-2-joe.hershberger@ni.com
State Accepted
Commit 14a8adebb559ca6dbf563a0246ad8d2241606879
Delegated to: Joe Hershberger
Headers show
Series [U-Boot,1/2] net: Fix Covarity Defect 244093 | expand

Commit Message

Joe Hershberger July 30, 2019, 9:57 p.m. UTC 
Document that the lack of breaks is intentional.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
---

 cmd/mdio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Joe Hershberger Sept. 4, 2019, 4:39 p.m. UTC | #1 
Hi Joe,

https://patchwork.ozlabs.org/patch/1139393/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox series

Patch

diff --git a/cmd/mdio.c b/cmd/mdio.c
index add6440813..22c8fbe856 100644
--- a/cmd/mdio.c
+++ b/cmd/mdio.c
@@ -253,12 +253,13 @@  static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	case 'w':
 		if (pos > 1)
 			data = simple_strtoul(argv[pos--], NULL, 16);
+		/* Intentional fall-through - Get reg for read and write */
 	case 'r':
 		if (pos > 1)
 			if (extract_reg_range(argv[pos--], &devadlo, &devadhi,
 					      &reglo, &reghi))
 				return CMD_RET_FAILURE;
-
+		/* Intentional fall-through - Get phy for all commands */
 	default:
 		if (pos > 1)
 			if (extract_phy_range(&argv[2], pos - 1, &bus,