[ovs-dev,ovn] OVN split: Remove make "modules_install" target
diff mbox series

Message ID 20190729125946.10179-1-lmartins@redhat.com
State New
Headers show
Series
  • [ovs-dev,ovn] OVN split: Remove make "modules_install" target
Related show

Commit Message

Lucas Alvares Gomes July 29, 2019, 12:59 p.m. UTC
From: Lucas Alvares Gomes <lucasagomes@gmail.com>

This patch is removing the make "modules_install" target for the new OVN
repository.

The target is not be needed for OVN (and is currently broken) becasue the
kernel modules should be compiled and installed using the OVS repository.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
---
 Makefile.am | 5 -----
 1 file changed, 5 deletions(-)

Comments

Mark Michelson July 29, 2019, 9:05 p.m. UTC | #1
Acked-by: Mark Michelson <mmichels@redhat.com>

On 7/29/19 8:59 AM, lmartins@redhat.com wrote:
> From: Lucas Alvares Gomes <lucasagomes@gmail.com>
> 
> This patch is removing the make "modules_install" target for the new OVN
> repository.
> 
> The target is not be needed for OVN (and is currently broken) becasue the
> kernel modules should be compiled and installed using the OVS repository.
> 
> Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
> ---
>   Makefile.am | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index e3dea1912..2a629b425 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -484,11 +484,6 @@ install-data-local: $(INSTALL_DATA_LOCAL)
>   uninstall-local: $(UNINSTALL_LOCAL)
>   .PHONY: $(DIST_HOOKS) $(CLEAN_LOCAL) $(INSTALL_DATA_LOCAL) $(UNINSTALL_LOCAL)
>   
> -modules_install:
> -if LINUX_ENABLED
> -	cd datapath/linux && $(MAKE) modules_install
> -endif
> -
>   dist-docs:
>   	VERSION=$(VERSION) MAKE='$(MAKE)' $(srcdir)/build-aux/dist-docs $(srcdir) $(docs)
>   .PHONY: dist-docs
>
Numan Siddique July 30, 2019, 4:20 a.m. UTC | #2
On Tue, Jul 30, 2019 at 2:40 AM Mark Michelson <mmichels@redhat.com> wrote:

> Acked-by: Mark Michelson <mmichels@redhat.com>
>
On 7/29/19 8:59 AM, lmartins@redhat.com wrote:
> > From: Lucas Alvares Gomes <lucasagomes@gmail.com>
> >
> > This patch is removing the make "modules_install" target for the new OVN
> > repository.
> >
> > The target is not be needed for OVN (and is currently broken) becasue the
> > kernel modules should be compiled and installed using the OVS repository.
> >
> > Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
>

Thanks. I applied this to master.

Numan


> > ---
> >   Makefile.am | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index e3dea1912..2a629b425 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -484,11 +484,6 @@ install-data-local: $(INSTALL_DATA_LOCAL)
> >   uninstall-local: $(UNINSTALL_LOCAL)
> >   .PHONY: $(DIST_HOOKS) $(CLEAN_LOCAL) $(INSTALL_DATA_LOCAL)
> $(UNINSTALL_LOCAL)
> >
> > -modules_install:
> > -if LINUX_ENABLED
> > -     cd datapath/linux && $(MAKE) modules_install
> > -endif
> > -
> >   dist-docs:
> >       VERSION=$(VERSION) MAKE='$(MAKE)' $(srcdir)/build-aux/dist-docs
> $(srcdir) $(docs)
> >   .PHONY: dist-docs
> >
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

Patch
diff mbox series

diff --git a/Makefile.am b/Makefile.am
index e3dea1912..2a629b425 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -484,11 +484,6 @@  install-data-local: $(INSTALL_DATA_LOCAL)
 uninstall-local: $(UNINSTALL_LOCAL)
 .PHONY: $(DIST_HOOKS) $(CLEAN_LOCAL) $(INSTALL_DATA_LOCAL) $(UNINSTALL_LOCAL)
 
-modules_install:
-if LINUX_ENABLED
-	cd datapath/linux && $(MAKE) modules_install
-endif
-
 dist-docs:
 	VERSION=$(VERSION) MAKE='$(MAKE)' $(srcdir)/build-aux/dist-docs $(srcdir) $(docs)
 .PHONY: dist-docs