| Message ID | 1563877928-19546-1-git-send-email-damjan.skvarc@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,1/1] Fixed memory leak in ovn-controller while handling port binding changes. | expand |
On Tue, Jul 23, 2019 at 12:33 PM Damijan Skvarc <damjan.skvarc@gmail.com> wrote: > > Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> Looks good to me. Thanks! Acked-by: Dumitru Ceara <dceara@redhat.com> > --- > ovn/controller/physical.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c > index 316d373..7ad3e6f 100644 > --- a/ovn/controller/physical.c > +++ b/ovn/controller/physical.c > @@ -1091,7 +1091,7 @@ void physical_handle_port_binding_changes( > flow_table, &ofpacts); > } > } > - > + ofpbuf_uninit(&ofpacts); > } > > void > -- > 2.7.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jul 23, 2019 at 4:47 PM Dumitru Ceara <dceara@redhat.com> wrote: > On Tue, Jul 23, 2019 at 12:33 PM Damijan Skvarc <damjan.skvarc@gmail.com> > wrote: > > > > Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> > > Looks good to me. Thanks! > Acked-by: Dumitru Ceara <dceara@redhat.com> > Thank for the fix. I pushed this patch to ovn master. We do need to backport this fix to branch 2.12. Thanks Numan > > > --- > > ovn/controller/physical.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c > > index 316d373..7ad3e6f 100644 > > --- a/ovn/controller/physical.c > > +++ b/ovn/controller/physical.c > > @@ -1091,7 +1091,7 @@ void physical_handle_port_binding_changes( > > flow_table, &ofpacts); > > } > > } > > - > > + ofpbuf_uninit(&ofpacts); > > } > > > > void > > -- > > 2.7.4 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
> On Aug 6, 2019, at 3:20 AM, Numan Siddique <nusiddiq@redhat.com> wrote: > > On Tue, Jul 23, 2019 at 4:47 PM Dumitru Ceara <dceara@redhat.com> wrote: > >> On Tue, Jul 23, 2019 at 12:33 PM Damijan Skvarc <damjan.skvarc@gmail.com> >> wrote: >>> >>> Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> >> >> Looks good to me. Thanks! >> Acked-by: Dumitru Ceara <dceara@redhat.com> >> > > Thank for the fix. I pushed this patch to ovn master. > > We do need to backport this fix to branch 2.12. Thanks. I backported it to branch-2.12. --Justin
diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c index 316d373..7ad3e6f 100644 --- a/ovn/controller/physical.c +++ b/ovn/controller/physical.c @@ -1091,7 +1091,7 @@ void physical_handle_port_binding_changes( flow_table, &ofpacts); } } - + ofpbuf_uninit(&ofpacts); } void
Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> --- ovn/controller/physical.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)