From patchwork Fri Jul 19 17:29:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 1134239 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="BKsEJ3v3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45qyj61Bzvz9s7T for ; Sat, 20 Jul 2019 03:31:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731608AbfGSRbV (ORCPT ); Fri, 19 Jul 2019 13:31:21 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:45967 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731555AbfGSRbU (ORCPT ); Fri, 19 Jul 2019 13:31:20 -0400 Received: by mail-qk1-f195.google.com with SMTP id s22so23814928qkj.12 for ; Fri, 19 Jul 2019 10:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N+R2ea1tEKnOYXNzoo9m2ROYIh/qM2HPnBPxGnIkdkQ=; b=BKsEJ3v3ZS94sYuU/t2aaHruyRnKYAqrrc9cu3awBtV8DtZRkOTVLJWVvHl2vtWO0b GDOtE4E6kI1M5ZxHZH9bJbU0fgQR05DmnPySk29uSWiG3cqW8VnGAnufsSEvYA4ede7X giw0rrvom7HbgLMz5LCeMGjZeZqdZqy6zF8qHu8dyAf89HcL2E8oIEEEM6Mk36CiqqFY iBNtyub3FEU65zLQd69UFWC1pKfH35P60SzD/HOjdYYMn9KgtDzPoAyqyFFzOqV+r7TP /al3kmgyZp6a0yR0JqAMuNAwOi63z5sd9q0rxIrvAPHDpxm4qQl/7OTit8jOOLb2MqEq G5rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N+R2ea1tEKnOYXNzoo9m2ROYIh/qM2HPnBPxGnIkdkQ=; b=DkissDsdpZ11JdRrwAV3zbK2BC5q+e1RjHYXVzU/Fs2PNphWD48fAAoEIWrAvojFIJ wpMQnd7xIjoZrKtaeC4/42EMrIpRVGRiRcOrYAxDk1a4j84NJknaDNoKsS0dLnGTN7Pa ThCUejERKcO20yhZY1DTONOci/zshJFT9IV8Fm0d8uBsuTyCiFajJtomBkpXQeU6AVsl sigSG0BZ54874GuCOP7TtQVfVLmlwtRsv/9AsatoTXWuJQCnbGLCTW7yl7K7xo0OdKdV t7z8rrpjor2NDlQYShBmJIJpGjC5UjzqxWrqR6GNyqyXURY7ogkX1eoGKpJCXNHT61+X F3Gw== X-Gm-Message-State: APjAAAUPVEUWN0K5Z/rSCuwQRNhDvSPw+UehjcquMM25kXbVYlsXBpnZ 2RS1FxEKVr9D69qKaEv30mEF1g== X-Google-Smtp-Source: APXvYqzrJf5pk7gDUSHmXQBjh95+wfb01Z1BxyQ6E2v++pRaw/BdH7EBtcQlNklcOD1j3SDC6i5wqA== X-Received: by 2002:ae9:eb16:: with SMTP id b22mr31713340qkg.160.1563557479697; Fri, 19 Jul 2019 10:31:19 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y3sm15568509qtj.46.2019.07.19.10.31.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 10:31:19 -0700 (PDT) From: Jakub Kicinski To: john.fastabend@gmail.com, alexei.starovoitov@gmail.com, daniel@iogearbox.net Cc: edumazet@google.com, netdev@vger.kernel.org, bpf@vger.kernel.org, Jakub Kicinski , Dirk van der Merwe Subject: [PATCH bpf v4 13/14] selftests/tls: close the socket with open record Date: Fri, 19 Jul 2019 10:29:26 -0700 Message-Id: <20190719172927.18181-14-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190719172927.18181-1-jakub.kicinski@netronome.com> References: <20190719172927.18181-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Add test which sends some data with MSG_MORE and then closes the socket (never calling send without MSG_MORE). This should make sure we clean up open records correctly. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- tools/testing/selftests/net/tls.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index 6d78bd050813..94a86ca882de 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -239,6 +239,16 @@ TEST_F(tls, msg_more) EXPECT_EQ(memcmp(buf, test_str, send_len), 0); } +TEST_F(tls, msg_more_unsent) +{ + char const *test_str = "test_read"; + int send_len = 10; + char buf[10]; + + EXPECT_EQ(send(self->fd, test_str, send_len, MSG_MORE), send_len); + EXPECT_EQ(recv(self->cfd, buf, send_len, MSG_DONTWAIT), -1); +} + TEST_F(tls, sendmsg_single) { struct msghdr msg;