[v2,1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs
diff mbox series

Message ID 20190716174214.11914-1-itsatharva@gmail.com
State Accepted
Headers show
Series
  • [v2,1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs
Related show

Commit Message

Atharva Lele July 16, 2019, 5:42 p.m. UTC
We don't use the GZIP environment variable to store GZIP options
anymore. So explicitly add -n argument to the GZIP call to ensure
reproducibility.

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v1 -> v2:
  - Reversed order of patches
---
 fs/common.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni July 17, 2019, 6:47 a.m. UTC | #1
Hello Atharva,

On Tue, 16 Jul 2019 23:12:13 +0530
Atharva Lele <itsatharva@gmail.com> wrote:

> We don't use the GZIP environment variable to store GZIP options
> anymore. So explicitly add -n argument to the GZIP call to ensure
> reproducibility.
> 
> Signed-off-by: Atharva Lele <itsatharva@gmail.com>
> Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Changes v1 -> v2:
>   - Reversed order of patches
> ---
>  fs/common.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, thanks! I had to reword a little bit the commit log of
PATCH 1/2, because the wording was no longer really appropriate after
you swapped the order of the two patches.

Thanks,

Thomas
Peter Korsgaard Aug. 4, 2019, 8:12 p.m. UTC | #2
>>>>> "Atharva" == Atharva Lele <itsatharva@gmail.com> writes:

 > We don't use the GZIP environment variable to store GZIP options
 > anymore. So explicitly add -n argument to the GZIP call to ensure
 > reproducibility.

 > Signed-off-by: Atharva Lele <itsatharva@gmail.com>
 > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2019.02.x and 2019.05.x, thanks.

Patch
diff mbox series

diff --git a/fs/common.mk b/fs/common.mk
index fceb38c5b9..ca46a331d6 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -115,7 +115,7 @@  ROOTFS_$(2)_FINAL_RECURSIVE_DEPENDENCIES = $$(sort \
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)_GZIP),y)
 ROOTFS_$(2)_COMPRESS_EXT = .gz
-ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c
+ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c -n
 endif
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)_BZIP2),y)
 ROOTFS_$(2)_COMPRESS_EXT = .bz2