diff mbox series

mtd: rawnand: ingenic: ingenic_nand: Add of_node_put() before return

Message ID 20190709172030.13581-1-nishkadg.linux@gmail.com
State Accepted
Delegated to: Miquel Raynal
Headers show
Series mtd: rawnand: ingenic: ingenic_nand: Add of_node_put() before return | expand

Commit Message

Nishka Dasgupta July 9, 2019, 5:20 p.m. UTC 
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
 drivers/mtd/nand/raw/ingenic/ingenic_nand.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand.c
index d7b7c0f13909..df214e7ddec8 100644
--- a/drivers/mtd/nand/raw/ingenic/ingenic_nand.c
+++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand.c
@@ -418,6 +418,7 @@  static int ingenic_nand_init_chips(struct ingenic_nfc *nfc,
 		ret = ingenic_nand_init_chip(pdev, nfc, np, i);
 		if (ret) {
 			ingenic_nand_cleanup_chips(nfc);
+			of_node_put(np);
 			return ret;
 		}