| Message ID | 20190703163959.23070-2-itsatharva@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] Makefile: don't export GZIP environment variable | expand |
Atharva, All, On 2019-07-03 22:09 +0530, Atharva Lele spake thusly: > We don't use the GZIP environment variable to store GZIP options, > so explicitly add -n argument here to increase reproducibility. This patch should come before the previous patch removing 'export GZIP'. Otherwise: Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > Signed-off-by: Atharva Lele <itsatharva@gmail.com> > --- > fs/common.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/common.mk b/fs/common.mk > index fceb38c5b9..ca46a331d6 100644 > --- a/fs/common.mk > +++ b/fs/common.mk > @@ -115,7 +115,7 @@ ROOTFS_$(2)_FINAL_RECURSIVE_DEPENDENCIES = $$(sort \ > > ifeq ($$(BR2_TARGET_ROOTFS_$(2)_GZIP),y) > ROOTFS_$(2)_COMPRESS_EXT = .gz > -ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c > +ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c -n > endif > ifeq ($$(BR2_TARGET_ROOTFS_$(2)_BZIP2),y) > ROOTFS_$(2)_COMPRESS_EXT = .bz2 > -- > 2.22.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/fs/common.mk b/fs/common.mk index fceb38c5b9..ca46a331d6 100644 --- a/fs/common.mk +++ b/fs/common.mk @@ -115,7 +115,7 @@ ROOTFS_$(2)_FINAL_RECURSIVE_DEPENDENCIES = $$(sort \ ifeq ($$(BR2_TARGET_ROOTFS_$(2)_GZIP),y) ROOTFS_$(2)_COMPRESS_EXT = .gz -ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c +ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c -n endif ifeq ($$(BR2_TARGET_ROOTFS_$(2)_BZIP2),y) ROOTFS_$(2)_COMPRESS_EXT = .bz2
We don't use the GZIP environment variable to store GZIP options, so explicitly add -n argument here to increase reproducibility. Signed-off-by: Atharva Lele <itsatharva@gmail.com> --- fs/common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)