[ovs-dev,1/1] dpif-netlink: Warn eth type 0x1234 not offloadable
diff mbox series

Message ID 20190630061605.11842-1-elibr@mellanox.com
State Changes Requested
Headers show
Series
  • [ovs-dev,1/1] dpif-netlink: Warn eth type 0x1234 not offloadable
Related show

Commit Message

Eli Britstein June 30, 2019, 6:16 a.m. UTC
Ethernet type 0x1234 is used for testing and not being offloadable. For
testing offloadable features, warn about using this value.

Signed-off-by: Eli Britstein <elibr@mellanox.com>
---
 lib/dpif-netlink.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Roi Dayan July 2, 2019, 11:21 a.m. UTC | #1
On 2019-06-30 9:16 AM, Eli Britstein wrote:
> Ethernet type 0x1234 is used for testing and not being offloadable. For
> testing offloadable features, warn about using this value.
> 
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> ---
>  lib/dpif-netlink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index ba80a0079..327076784 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -2007,6 +2007,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>  
>      /* When we try to install a dummy flow from a probed feature. */
>      if (match.flow.dl_type == htons(0x1234)) {
> +        VLOG_WARN("eth 0x1234 is special and not offloadable");
>          return EOPNOTSUPP;
>      }
>  
> 

why a warn is needed?
Roi Dayan July 2, 2019, 11:33 a.m. UTC | #2
On 2019-07-02 2:21 PM, Roi Dayan wrote:
> 
> 
> On 2019-06-30 9:16 AM, Eli Britstein wrote:
>> Ethernet type 0x1234 is used for testing and not being offloadable. For
>> testing offloadable features, warn about using this value.
>>
>> Signed-off-by: Eli Britstein <elibr@mellanox.com>
>> ---
>>  lib/dpif-netlink.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
>> index ba80a0079..327076784 100644
>> --- a/lib/dpif-netlink.c
>> +++ b/lib/dpif-netlink.c
>> @@ -2007,6 +2007,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>>  
>>      /* When we try to install a dummy flow from a probed feature. */
>>      if (match.flow.dl_type == htons(0x1234)) {
>> +        VLOG_WARN("eth 0x1234 is special and not offloadable");
>>          return EOPNOTSUPP;
>>      }
>>  
>>
> 
> why a warn is needed?

nm. somehow skipped your commit msg.
did u check by any chance if unit tests won't fail as they need to filter this from the log?

> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=02%7C01%7Croid%40mellanox.com%7Ce8fb39de2ec84d799be308d6fedfa943%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636976633920052415&amp;sdata=VHoqOa8rylBZNj9q8W3fa4H3xx55NK3qR2tEDvBIeRg%3D&amp;reserved=0
>
Roi Dayan July 2, 2019, 11:53 a.m. UTC | #3
On 2019-07-02 2:33 PM, Roi Dayan wrote:
> 
> 
> On 2019-07-02 2:21 PM, Roi Dayan wrote:
>>
>>
>> On 2019-06-30 9:16 AM, Eli Britstein wrote:
>>> Ethernet type 0x1234 is used for testing and not being offloadable. For
>>> testing offloadable features, warn about using this value.
>>>
>>> Signed-off-by: Eli Britstein <elibr@mellanox.com>
>>> ---
>>>  lib/dpif-netlink.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
>>> index ba80a0079..327076784 100644
>>> --- a/lib/dpif-netlink.c
>>> +++ b/lib/dpif-netlink.c
>>> @@ -2007,6 +2007,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>>>  
>>>      /* When we try to install a dummy flow from a probed feature. */
>>>      if (match.flow.dl_type == htons(0x1234)) {
>>> +        VLOG_WARN("eth 0x1234 is special and not offloadable");
>>>          return EOPNOTSUPP;
>>>      }
>>>  
>>>
>>
>> why a warn is needed?
> 
> nm. somehow skipped your commit msg.
> did u check by any chance if unit tests won't fail as they need to filter this from the log?
> 
tested here. didnt need to filter it.

https://travis-ci.org/roidayan/ovs/builds/553249802

Acked-by: Roi Dayan <roid@mellanox.com>

>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=02%7C01%7Croid%40mellanox.com%7C8103de0801a340b6fce008d6fee142cb%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636976640787761456&amp;sdata=BUPGrfzUwJjVLPoBT6miPjsxXvXhC6XIELUTvtfnFe0%3D&amp;reserved=0
>>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=02%7C01%7Croid%40mellanox.com%7C8103de0801a340b6fce008d6fee142cb%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636976640787771450&amp;sdata=Z5%2BCwEWOsZSXVI%2BZcCM0l0B9%2BzpBP%2F1YOT07Ai2u7tc%3D&amp;reserved=0
>
Ben Pfaff July 2, 2019, 5:04 p.m. UTC | #4
On Sun, Jun 30, 2019 at 06:16:05AM +0000, Eli Britstein wrote:
> Ethernet type 0x1234 is used for testing and not being offloadable. For
> testing offloadable features, warn about using this value.
> 
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> ---
>  lib/dpif-netlink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index ba80a0079..327076784 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -2007,6 +2007,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>  
>      /* When we try to install a dummy flow from a probed feature. */
>      if (match.flow.dl_type == htons(0x1234)) {
> +        VLOG_WARN("eth 0x1234 is special and not offloadable");
>          return EOPNOTSUPP;
>      }

This should be rate-limited.

Are you sure that you want it to be a warning?  It does not seem to be
an actual problem, so INFO or even DBG might be better.

Patch
diff mbox series

diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index ba80a0079..327076784 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -2007,6 +2007,7 @@  parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
 
     /* When we try to install a dummy flow from a probed feature. */
     if (match.flow.dl_type == htons(0x1234)) {
+        VLOG_WARN("eth 0x1234 is special and not offloadable");
         return EOPNOTSUPP;
     }