| Message ID | 156078063349.435533.12283208810037409702.stgit@bahia.lan |
|---|---|
| State | New |
| Headers | show |
| Series | xics: Add comment about CPU hotplug | expand |
On 17/06/2019 16:10, Greg Kurz wrote: > So that no one is tempted to drop that code, which is never called > for cold plugged CPUs. > > Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C.
On Mon, Jun 17, 2019 at 04:10:33PM +0200, Greg Kurz wrote: > So that no one is tempted to drop that code, which is never called > for cold plugged CPUs. > > Signed-off-by: Greg Kurz <groug@kaod.org> Applied, thanks. > --- > hw/intc/xics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/intc/xics.c b/hw/intc/xics.c > index 8535e583dd41..faa976e2f8a8 100644 > --- a/hw/intc/xics.c > +++ b/hw/intc/xics.c > @@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp) > return; > } > > + /* Connect the presenter to the VCPU (required for CPU hotplug) */ > if (kvm_irqchip_in_kernel()) { > icp_kvm_realize(dev, &err); > if (err) { >
diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 8535e583dd41..faa976e2f8a8 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp) return; } + /* Connect the presenter to the VCPU (required for CPU hotplug) */ if (kvm_irqchip_in_kernel()) { icp_kvm_realize(dev, &err); if (err) {
So that no one is tempted to drop that code, which is never called for cold plugged CPUs. Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/intc/xics.c | 1 + 1 file changed, 1 insertion(+)