From patchwork Sun Jun 9 17:19:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 1112691 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Rr58f2nc"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45MNKk4vyXz9s3l for ; Mon, 10 Jun 2019 03:19:21 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1F62FCB2; Sun, 9 Jun 2019 17:19:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D17D0A55 for ; Sun, 9 Jun 2019 17:19:17 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9CDA87F8 for ; Sun, 9 Jun 2019 17:19:17 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id d126so3920013pfd.2 for ; Sun, 09 Jun 2019 10:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=VOA+z+jGkv5MT303wn1Ym/wuSaJNCg2BrjPXz+dA91I=; b=Rr58f2ncR/UkjyZV03o0J9oVL2pZq8mTbtLy/gBSpmBgcm8gG2bQYUM+IxvKNMc8hu EYYusOZG7yPnllFU7L0waRaVDrsoMUR/cgPmbzyHwVWeYsAyDLnCv+CQwguu90u/hKT3 UucbdWFGU11Libqqhjvqh/QABoxLqzIn/9oXs2MvT+PhMWgQ1Hf85RoOvrN83VmkRq3r sVlNZAC9BIiJwp0ki6DzPMK7xIasXDFst6sBy4kZeqbrcfqh2q6cVhvDNiiY6MkXX6j0 B4Q0O+BFDZUQ/gT7niB542REXN4dexALv3054BLQsWZ0Y8FZu4MzWZt54piA1U/WUjNt Ih1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VOA+z+jGkv5MT303wn1Ym/wuSaJNCg2BrjPXz+dA91I=; b=Y4P6Li89fZhaNhxWO7bWq5DAhIixjOkg78cohHuMBzwvR7FbzmVFXS9RWrytKaJJ4j nUxUj0mH0ZWKqBp9I7s1NF5qNbEtDfeG2gpnqD4iqY+l9+2raSlsMFZH3/2zFLDn3Zgn 63/gLUuN5w9wqj3m7Mv27d9GneylJNx+o+teSZ1wHNYfvT5OzzBX/FJm1bNFcidEXz6h 6zOc+U1vyWA6BPi6ot4JrVgfG1Sz8EcELqlxOyJgv6m8x5JGyMilJ5/SVIV2kd7dwdM3 SRJ5/WKsFaYWNBqaiV3qhFxc6XrMg9Khk9xF0Fvfai+X5yP/7/DcHVcj7tXkE3xoHuDT IGsA== X-Gm-Message-State: APjAAAWwPw23fdLAbhpmY25OLPOaHW4smPBWJpETtYCRYWWEQIHrzxyZ kIp0EmVMVrNfB4zaXDEpHzzegLRC X-Google-Smtp-Source: APXvYqwp6tPkHpG7+5VnTaVLU3AJSHl9Oy7sFmtbG0h1qahwYs1tTxpK1v7vG6KPJvax1AgmudZcGw== X-Received: by 2002:a63:a056:: with SMTP id u22mr12106459pgn.318.1560100757034; Sun, 09 Jun 2019 10:19:17 -0700 (PDT) Received: from ap-To-be-filled-by-O-E-M.8.8.8.8 ([14.33.120.60]) by smtp.gmail.com with ESMTPSA id b66sm9421039pfa.77.2019.06.09.10.19.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Jun 2019 10:19:16 -0700 (PDT) From: Taehee Yoo To: davem@davemloft.net, pshelar@ovn.org, netdev@vger.kernel.org, dev@openvswitch.org Date: Mon, 10 Jun 2019 02:19:06 +0900 Message-Id: <20190609171906.30314-1-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del() X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org ASSERT_OVSL() in ovs_vport_del() is unnecessary because ovs_vport_del() is only called by ovs_dp_detach_port() and ovs_dp_detach_port() calls ASSERT_OVSL() too. Signed-off-by: Taehee Yoo Reviewed-by: Greg Rose --- net/openvswitch/vport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 258ce3b7b452..9e71f1a601a9 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options) */ void ovs_vport_del(struct vport *vport) { - ASSERT_OVSL(); - hlist_del_rcu(&vport->hash_node); module_put(vport->ops->owner); vport->ops->destroy(vport);