| Message ID | 20190609171906.30314-1-ap420073@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | [ovs-dev,net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del() | expand |
On 6/9/2019 10:19 AM, Taehee Yoo wrote: > ASSERT_OVSL() in ovs_vport_del() is unnecessary because > ovs_vport_del() is only called by ovs_dp_detach_port() and > ovs_dp_detach_port() calls ASSERT_OVSL() too. > > Signed-off-by: Taehee Yoo <ap420073@gmail.com> > --- > net/openvswitch/vport.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index 258ce3b7b452..9e71f1a601a9 100644 > --- a/net/openvswitch/vport.c > +++ b/net/openvswitch/vport.c > @@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options) > */ > void ovs_vport_del(struct vport *vport) > { > - ASSERT_OVSL(); > - > hlist_del_rcu(&vport->hash_node); > module_put(vport->ops->owner); > vport->ops->destroy(vport); LGTM Reviewed-by: Greg Rose <gvrose8192@gmail.com>
From: Taehee Yoo <ap420073@gmail.com> Date: Mon, 10 Jun 2019 02:19:06 +0900 > ASSERT_OVSL() in ovs_vport_del() is unnecessary because > ovs_vport_del() is only called by ovs_dp_detach_port() and > ovs_dp_detach_port() calls ASSERT_OVSL() too. > > Signed-off-by: Taehee Yoo <ap420073@gmail.com> Applied.
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 258ce3b7b452..9e71f1a601a9 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options) */ void ovs_vport_del(struct vport *vport) { - ASSERT_OVSL(); - hlist_del_rcu(&vport->hash_node); module_put(vport->ops->owner); vport->ops->destroy(vport);
ASSERT_OVSL() in ovs_vport_del() is unnecessary because ovs_vport_del() is only called by ovs_dp_detach_port() and ovs_dp_detach_port() calls ASSERT_OVSL() too. Signed-off-by: Taehee Yoo <ap420073@gmail.com> --- net/openvswitch/vport.c | 2 -- 1 file changed, 2 deletions(-)