diff mbox series

[ovs-dev] ofproto-dpif-xlate: Report DHCP output actions in trace.

Message ID 20190607190919.20548-1-blp@ovn.org
State Accepted
Commit b1986b08b97cb063be97ba3a7c5cb885e10e1ffe
Headers show
Series [ovs-dev] ofproto-dpif-xlate: Report DHCP output actions in trace. | expand

Commit Message

Ben Pfaff June 7, 2019, 7:09 p.m. UTC 
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 ofproto/ofproto-dpif-xlate.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

0-day Robot June 7, 2019, 8 p.m. UTC | #1 
Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#17 FILE: ofproto/ofproto-dpif-xlate.c:1:
/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2019 Nicira, Inc.

Lines checked: 32, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
Yifeng Sun June 7, 2019, 10:34 p.m. UTC | #2 
Look good to me, thanks.

Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>

On Fri, Jun 7, 2019 at 1:03 PM 0-day Robot <robot@bytheb.org> wrote:
>
> Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> checkpatch:
> WARNING: Line is 88 characters long (recommended limit is 79)
> #17 FILE: ofproto/ofproto-dpif-xlate.c:1:
> /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2019 Nicira, Inc.
>
> Lines checked: 32, Warnings: 1, Errors: 0
>
>
> Please check this out.  If you feel there has been an error, please email aconole@bytheb.org
>
> Thanks,
> 0-day Robot
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff June 7, 2019, 11:31 p.m. UTC | #3 
Thanks, applied to master.

On Fri, Jun 07, 2019 at 03:34:04PM -0700, Yifeng Sun wrote:
> Look good to me, thanks.
> 
> Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
> 
> On Fri, Jun 7, 2019 at 1:03 PM 0-day Robot <robot@bytheb.org> wrote:
> >
> > Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't expecting.  See the details below.
> >
> >
> > checkpatch:
> > WARNING: Line is 88 characters long (recommended limit is 79)
> > #17 FILE: ofproto/ofproto-dpif-xlate.c:1:
> > /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2019 Nicira, Inc.
> >
> > Lines checked: 32, Warnings: 1, Errors: 0
> >
> >
> > Please check this out.  If you feel there has been an error, please email aconole@bytheb.org
> >
> > Thanks,
> > 0-day Robot
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff mbox series

Patch

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 04d69ed06c20..ea72eedb1cde 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -1,4 +1,4 @@ 
-/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.
+/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2019 Nicira, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -7588,6 +7588,8 @@  xlate_actions(struct xlate_in *xin, struct xlate_out *xout)
             WC_MASK_FIELD(ctx.wc, tp_src);
             WC_MASK_FIELD(ctx.wc, tp_dst);
             WC_MASK_FIELD(ctx.wc, dl_type);
+            xlate_report(&ctx, OFT_DETAIL, "outputting DHCP packet "
+                         "to local port for in-band control");
             compose_output_action(&ctx, OFPP_LOCAL, NULL, false, false);
         }