| Message ID | 20190522072201.5130-3-peng.fan@nxp.com |
|---|---|
| State | Accepted |
| Commit | 4213609cc7fb78f84b2ea63f4a5691b60d01c248 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,V2,1/3] test: dm: adc: use the real device name | expand |
On Wed, May 22, 2019 at 3:08 PM Peng Fan <peng.fan@nxp.com> wrote: > > `if (!strncmp(dev->name, name, strlen(name)))` might find out > the wrong device, it might find out `dram_pll_ref_sel`, when name is > `dram_pll`. So use strcmp to avoid such issue. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > > V2: > None > > drivers/core/uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Wed, May 22, 2019 at 07:08:14AM +0000, Peng Fan wrote: > `if (!strncmp(dev->name, name, strlen(name)))` might find out > the wrong device, it might find out `dram_pll_ref_sel`, when name is > `dram_pll`. So use strcmp to avoid such issue. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot/master, thanks!
diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index fc3157de39..e2f35393a9 100644 --- a/drivers/core/uclass.c +++ b/drivers/core/uclass.c @@ -260,7 +260,7 @@ int uclass_find_device_by_name(enum uclass_id id, const char *name, return ret; uclass_foreach_dev(dev, uc) { - if (!strncmp(dev->name, name, strlen(name))) { + if (!strcmp(dev->name, name)) { *devp = dev; return 0; }