diff mbox series

[ovs-dev,v3,3/3] OVN ACL: Allow a user to input ct.label value for an acl

Message ID 1555459154-103091-4-git-send-email-ankur.sharma@nutanix.com
State Superseded
Headers show
Series Associate identifier with OVN ACL connection tracking entry | expand

Commit Message

Ankur Sharma April 16, 2019, 11:58 p.m. UTC 
This patch allows user to associate a value with acl,
which will be assigned to ct.label of the corresponding
connection tracking entry.

This value can be used to map a ct entry with corresponding
OVN ACL or higher level constructs like security group.

Signed-off-by: Ankur Sharma <ankur.sharma@nutanix.com>
---
 ovn/ovn-nb.ovsschema | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ben Pfaff April 17, 2019, 5:45 p.m. UTC | #1 
On Tue, Apr 16, 2019 at 11:58:10PM +0000, Ankur Sharma wrote:
> This patch allows user to associate a value with acl,
> which will be assigned to ct.label of the corresponding
> connection tracking entry.
> 
> This value can be used to map a ct entry with corresponding
> OVN ACL or higher level constructs like security group.
> 
> Signed-off-by: Ankur Sharma <ankur.sharma@nutanix.com>
> ---
>  ovn/ovn-nb.ovsschema | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema
> index 2c87cbb..4391e3b 100644
> --- a/ovn/ovn-nb.ovsschema
> +++ b/ovn/ovn-nb.ovsschema
> @@ -1,7 +1,7 @@
>  {
>      "name": "OVN_Northbound",
> -    "version": "5.16.0",
> -    "cksum": "923459061 23095",
> +    "version": "5.17.0",
> +    "cksum": "3491001412 23095",
>      "tables": {
>          "NB_Global": {
>              "columns": {

This patch seems like it's a mistake since it only updates the version
and checksum.
Ankur Sharma April 17, 2019, 11:02 p.m. UTC | #2 
Hi Ben,

Sorry, somehow messed up the 3rd patch.
Submitted a v4 of this series.

Thanks

Regards,
Ankur

-----Original Message-----
From: Ben Pfaff <blp@ovn.org> 
Sent: Wednesday, April 17, 2019 10:46 AM
To: Ankur Sharma <ankur.sharma@nutanix.com>
Cc: ovs-dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

On Tue, Apr 16, 2019 at 11:58:10PM +0000, Ankur Sharma wrote:
> This patch allows user to associate a value with acl, which will be 
> assigned to ct.label of the corresponding connection tracking entry.
> 
> This value can be used to map a ct entry with corresponding OVN ACL or 
> higher level constructs like security group.
> 
> Signed-off-by: Ankur Sharma <ankur.sharma@nutanix.com>
> ---
>  ovn/ovn-nb.ovsschema | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema index 
> 2c87cbb..4391e3b 100644
> --- a/ovn/ovn-nb.ovsschema
> +++ b/ovn/ovn-nb.ovsschema
> @@ -1,7 +1,7 @@
>  {
>      "name": "OVN_Northbound",
> -    "version": "5.16.0",
> -    "cksum": "923459061 23095",
> +    "version": "5.17.0",
> +    "cksum": "3491001412 23095",
>      "tables": {
>          "NB_Global": {
>              "columns": {

This patch seems like it's a mistake since it only updates the version and checksum.
Ben Pfaff April 22, 2019, 8:29 p.m. UTC | #3 
It looks like you might have missed the comments I made on patch 2 of
v3, you can see them here:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-April/358280.html

On Wed, Apr 17, 2019 at 11:02:53PM +0000, Ankur Sharma wrote:
> Hi Ben,
> 
> Sorry, somehow messed up the 3rd patch.
> Submitted a v4 of this series.
> 
> Thanks
> 
> Regards,
> Ankur
> 
> -----Original Message-----
> From: Ben Pfaff <blp@ovn.org> 
> Sent: Wednesday, April 17, 2019 10:46 AM
> To: Ankur Sharma <ankur.sharma@nutanix.com>
> Cc: ovs-dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl
> 
> On Tue, Apr 16, 2019 at 11:58:10PM +0000, Ankur Sharma wrote:
> > This patch allows user to associate a value with acl, which will be 
> > assigned to ct.label of the corresponding connection tracking entry.
> > 
> > This value can be used to map a ct entry with corresponding OVN ACL or 
> > higher level constructs like security group.
> > 
> > Signed-off-by: Ankur Sharma <ankur.sharma@nutanix.com>
> > ---
> >  ovn/ovn-nb.ovsschema | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema index 
> > 2c87cbb..4391e3b 100644
> > --- a/ovn/ovn-nb.ovsschema
> > +++ b/ovn/ovn-nb.ovsschema
> > @@ -1,7 +1,7 @@
> >  {
> >      "name": "OVN_Northbound",
> > -    "version": "5.16.0",
> > -    "cksum": "923459061 23095",
> > +    "version": "5.17.0",
> > +    "cksum": "3491001412 23095",
> >      "tables": {
> >          "NB_Global": {
> >              "columns": {
> 
> This patch seems like it's a mistake since it only updates the version and checksum.
Ankur Sharma April 22, 2019, 8:40 p.m. UTC | #4 
Hi Ben,

You are right, somehow missed these comments.
Will submit a v4 soon.

Thanks

Regards,
Ankur

-----Original Message-----
From: Ben Pfaff <blp@ovn.org> 
Sent: Monday, April 22, 2019 1:30 PM
To: Ankur Sharma <ankur.sharma@nutanix.com>
Cc: ovs-dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

It looks like you might have missed the comments I made on patch 2 of v3, you can see them here:
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2019-2DApril_358280.html&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=mZwX9gFQgeJHzTg-68aCJgsODyUEVsHGFOfL90J6MJY&m=YCnMIx1Aece6itgww1UH2VhZkfC6us3WVXzItyJqekM&s=DDJDIB-GKo9AyuPbMWwXUAjuPtZBQGXQ6Gvsior2_e8&e=

On Wed, Apr 17, 2019 at 11:02:53PM +0000, Ankur Sharma wrote:
> Hi Ben,
> 
> Sorry, somehow messed up the 3rd patch.
> Submitted a v4 of this series.
> 
> Thanks
> 
> Regards,
> Ankur
> 
> -----Original Message-----
> From: Ben Pfaff <blp@ovn.org>
> Sent: Wednesday, April 17, 2019 10:46 AM
> To: Ankur Sharma <ankur.sharma@nutanix.com>
> Cc: ovs-dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input 
> ct.label value for an acl
> 
> On Tue, Apr 16, 2019 at 11:58:10PM +0000, Ankur Sharma wrote:
> > This patch allows user to associate a value with acl, which will be 
> > assigned to ct.label of the corresponding connection tracking entry.
> > 
> > This value can be used to map a ct entry with corresponding OVN ACL 
> > or higher level constructs like security group.
> > 
> > Signed-off-by: Ankur Sharma <ankur.sharma@nutanix.com>
> > ---
> >  ovn/ovn-nb.ovsschema | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema index 
> > 2c87cbb..4391e3b 100644
> > --- a/ovn/ovn-nb.ovsschema
> > +++ b/ovn/ovn-nb.ovsschema
> > @@ -1,7 +1,7 @@
> >  {
> >      "name": "OVN_Northbound",
> > -    "version": "5.16.0",
> > -    "cksum": "923459061 23095",
> > +    "version": "5.17.0",
> > +    "cksum": "3491001412 23095",
> >      "tables": {
> >          "NB_Global": {
> >              "columns": {
> 
> This patch seems like it's a mistake since it only updates the version and checksum.
diff mbox series

Patch

diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema
index 2c87cbb..4391e3b 100644
--- a/ovn/ovn-nb.ovsschema
+++ b/ovn/ovn-nb.ovsschema
@@ -1,7 +1,7 @@ 
 {
     "name": "OVN_Northbound",
-    "version": "5.16.0",
-    "cksum": "923459061 23095",
+    "version": "5.17.0",
+    "cksum": "3491001412 23095",
     "tables": {
         "NB_Global": {
             "columns": {